From: Phil Sutter <phil@nwl.cc>
To: Fabio Pedretti <pedretti.fabio@gmail.com>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [iptables PATCH] man: recent: Adjust to changes around ip_pkt_list_tot parameter
Date: Wed, 12 Jun 2024 21:49:20 +0200 [thread overview]
Message-ID: <Zmn7wA65yWzhbB5M@orbyte.nwl.cc> (raw)
In-Reply-To: <CA+fnjVC2vZpowThMGEvRT=vuEHW5cdzxPTHgWkjO1o+TpZo5Cg@mail.gmail.com>
On Wed, Jun 12, 2024 at 06:00:54PM +0200, Fabio Pedretti wrote:
> Hi, thanks.
> It looks like there is still a limit of 255 for hitcount (and
> ip_pkt_list_tot), right?
Yeah, that's a kernel limitation, namely XT_RECENT_MAX_NSTAMPS. We may
lift or even drop that, but it will require a separate patch either way.
> Maybe leave:
> The maximum value for the hitcount parameter is 255.
>
> Even better, remove the limit? :)
I see that struct recent_table::nstamps_max_mask must hold the value of
the next power of two of the given hitcount (minus one) and is currently
a u8. So there will never be no limit, but one could use a u32 in that
place and set XT_RECENT_MAX_NSTAMPS to 0xffffffff.
I'll send a patch so we have something to discuss.
Cheers, Phil
next prev parent reply other threads:[~2024-06-12 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:13 [iptables PATCH] man: recent: Adjust to changes around ip_pkt_list_tot parameter Phil Sutter
2024-06-12 16:00 ` Fabio Pedretti
2024-06-12 19:49 ` Phil Sutter [this message]
2024-07-05 17:18 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zmn7wA65yWzhbB5M@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pedretti.fabio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).