netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [iptables PATCH] man: extensions: recent: Clarify default value of ip_list_hash_size
@ 2024-06-12 12:41 Phil Sutter
  2024-06-12 20:44 ` Phil Sutter
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2024-06-12 12:41 UTC (permalink / raw)
  To: netfilter-devel

The default value of 0 is a bit confusing.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 extensions/libxt_recent.man | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/extensions/libxt_recent.man b/extensions/libxt_recent.man
index 419be2579594d..82537fab9846f 100644
--- a/extensions/libxt_recent.man
+++ b/extensions/libxt_recent.man
@@ -97,7 +97,9 @@ Number of addresses remembered per table.
 Number of packets per address remembered.
 .TP
 \fBip_list_hash_size\fP=\fI0\fP
-Hash table size. 0 means to calculate it based on ip_list_tot, default: 512.
+Hash table size. 0 means to calculate it based on ip_list_tot by rounding it up
+to the next power of two (with \fBip_list_tot\fP defaulting to \fI100\fP,
+\fBip_list_hash_size\fP will calculate to \fI128\fP by default).
 .TP
 \fBip_list_perms\fP=\fI0644\fP
 Permissions for /proc/net/xt_recent/* files.
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [iptables PATCH] man: extensions: recent: Clarify default value of ip_list_hash_size
  2024-06-12 12:41 [iptables PATCH] man: extensions: recent: Clarify default value of ip_list_hash_size Phil Sutter
@ 2024-06-12 20:44 ` Phil Sutter
  0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2024-06-12 20:44 UTC (permalink / raw)
  To: netfilter-devel

On Wed, Jun 12, 2024 at 02:41:07PM +0200, Phil Sutter wrote:
> The default value of 0 is a bit confusing.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Patch applied after adding some missing tags:

Reported-by: Fabio <pedretti.fabio@gmail.com>
Link: https://bugzilla.netfilter.org/show_bug.cgi?id=1745


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-12 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-12 12:41 [iptables PATCH] man: extensions: recent: Clarify default value of ip_list_hash_size Phil Sutter
2024-06-12 20:44 ` Phil Sutter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).