From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>, Eric Garver <eric@garver.life>,
netfilter-devel@vger.kernel.org, nhofmeyr@sysmocom.de
Subject: Re: [PATCH nft 2/2,v2] cache: recycle existing cache with incremental updates
Date: Wed, 24 Jul 2024 09:51:42 +0200 [thread overview]
Message-ID: <ZqCyjliV3rYWVxYn@calendula> (raw)
In-Reply-To: <Zp_HmLb2r3nYeBBb@orbyte.nwl.cc>
On Tue, Jul 23, 2024 at 05:09:12PM +0200, Phil Sutter wrote:
[...]
> I don't like the commit because it breaks with the assumption that
> kernel genid matching cache genid means cache is up to date. It may
> indeed be, but I think it's thin ice and caching code is pretty complex
> as-is. :/
Right.
It is possible to retrieve the generation ID from the batch via
NLM_F_ECHO and the NFT_MSG_GETGEN to answer the question: "Was it
myself that has updated the ruleset last time?".
And this needs a lot more tests for -i/--interactive which is a
similar path to what daemons will exercise to ensure cache
consistency.
next prev parent reply other threads:[~2024-07-24 7:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 15:28 [PATCH nft 1/2,v2] cache: check for NFT_CACHE_REFRESH in current requested cache too Pablo Neira Ayuso
2024-05-28 15:28 ` [PATCH nft 2/2,v2] cache: recycle existing cache with incremental updates Pablo Neira Ayuso
2024-07-22 20:48 ` Eric Garver
2024-07-22 21:34 ` Pablo Neira Ayuso
2024-07-23 5:29 ` Phil Sutter
2024-07-23 11:56 ` Phil Sutter
2024-07-23 12:19 ` Pablo Neira Ayuso
2024-07-23 12:57 ` Pablo Neira Ayuso
2024-07-23 15:09 ` Phil Sutter
2024-07-24 7:51 ` Pablo Neira Ayuso [this message]
2024-07-23 14:34 ` Phil Sutter
2024-07-23 19:30 ` Eric Garver
2024-07-23 20:56 ` Phil Sutter
2024-07-24 7:44 ` Pablo Neira Ayuso
2024-07-24 11:51 ` Eric Garver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqCyjliV3rYWVxYn@calendula \
--to=pablo@netfilter.org \
--cc=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhofmeyr@sysmocom.de \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).