netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2 0/2] netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c
Date: Tue, 3 Sep 2024 18:14:34 +0200	[thread overview]
Message-ID: <Ztc16pw4r3Tf_U7h@calendula> (raw)
In-Reply-To: <20240829154739.16691-1-ubizjak@gmail.com>

Hi,

On Thu, Aug 29, 2024 at 05:29:30PM +0200, Uros Bizjak wrote:
> Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic
> and percpu address spaces and add __percpu annotation to *stats pointer
> to fix percpu address space issues.

IIRC, you submitted patch 1/2 in this series to the mm tree.

Let us know if this patch gets upstreamed via MM tree (if mm
maintainers are fine with it) or maybe MM maintainers prefer an
alternative path for this.

Thanks.

> NOTE: The patch depends on a patch that introduces *_PCPU() macros [1]
> that is on the way to mainline through the mm tree. For convience, the
> patch is included in this patch series, so CI tester is able to test
> the second patch without compile failures.
> 
> [1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/
> 
> The netfilter patch obsoletes patch [2].
> 
> [2] https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240806102808.804619-1-ubizjak@gmail.com/
> 
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> 
> Uros Bizjak (2):
>   err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros
>   netfilter: nf_tables: Fix percpu address space issues in
>     nf_tables_api.c
> 
>  include/linux/err.h           |  9 +++++++++
>  net/netfilter/nf_tables_api.c | 16 ++++++++--------
>  2 files changed, 17 insertions(+), 8 deletions(-)
> 
> -- 
> 2.42.0
> 

  parent reply	other threads:[~2024-09-03 16:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29 15:29 [PATCH v2 0/2] netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c Uros Bizjak
2024-08-29 15:29 ` [PATCH v2 1/2] err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros Uros Bizjak
2024-08-29 15:29 ` [PATCH v2 2/2] netfilter: nf_tables: Fix percpu address space issues in nf_tables_api.c Uros Bizjak
2024-08-30 17:07   ` Simon Horman
2024-10-04 11:13   ` Pablo Neira Ayuso
2024-09-03 16:14 ` Pablo Neira Ayuso [this message]
2024-09-03 16:19   ` [PATCH v2 0/2] " Uros Bizjak
2024-09-03 16:23     ` Pablo Neira Ayuso
2024-09-22  9:04   ` Uros Bizjak
2024-09-22 21:13     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ztc16pw4r3Tf_U7h@calendula \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).