* [nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh
@ 2024-09-19 12:40 Phil Sutter
2024-09-19 12:51 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2024-09-19 12:40 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
If the client can't reach the server, the latter remains listening
forever. Kill it after 5s of waiting.
Fixes: 867d2190799ab ("selftests: netfilter: add ipvs test script")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
Changes since v1:
- Don't rely upon availability of 'waitpid' but use 'timeout' instead.
---
tools/testing/selftests/net/netfilter/ipvs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/netfilter/ipvs.sh b/tools/testing/selftests/net/netfilter/ipvs.sh
index 4ceee9fb3949..d3edb16cd4b3 100755
--- a/tools/testing/selftests/net/netfilter/ipvs.sh
+++ b/tools/testing/selftests/net/netfilter/ipvs.sh
@@ -97,7 +97,7 @@ cleanup() {
}
server_listen() {
- ip netns exec "$ns2" socat -u -4 TCP-LISTEN:8080,reuseaddr STDOUT > "${outfile}" &
+ ip netns exec "$ns2" timeout 5 socat -u -4 TCP-LISTEN:8080,reuseaddr STDOUT > "${outfile}" &
server_pid=$!
sleep 0.2
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh
2024-09-19 12:40 [nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh Phil Sutter
@ 2024-09-19 12:51 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2024-09-19 12:51 UTC (permalink / raw)
To: Phil Sutter; +Cc: netfilter-devel
On Thu, Sep 19, 2024 at 02:40:00PM +0200, Phil Sutter wrote:
> If the client can't reach the server, the latter remains listening
> forever. Kill it after 5s of waiting.
This looks more similar to what I have seen.
I have to admit I am still learning the common idioms that are used in
selftest.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-19 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-19 12:40 [nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh Phil Sutter
2024-09-19 12:51 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).