[nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh

[nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh

[Phil Sutter]

If the client can't reach the server, the latter remains listening
forever. Kill it after 5s of waiting.

Fixes: 867d2190799ab ("selftests: netfilter: add ipvs test script")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
Changes since v1:
- Don't rely upon availability of 'waitpid' but use 'timeout' instead.
---
 tools/testing/selftests/net/netfilter/ipvs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/netfilter/ipvs.sh b/tools/testing/selftests/net/netfilter/ipvs.sh
index 4ceee9fb3949..d3edb16cd4b3 100755
--- a/tools/testing/selftests/net/netfilter/ipvs.sh
+++ b/tools/testing/selftests/net/netfilter/ipvs.sh
@@ -97,7 +97,7 @@ cleanup() {
 }
 
 server_listen() {
-	ip netns exec "$ns2" socat -u -4 TCP-LISTEN:8080,reuseaddr STDOUT > "${outfile}" &
+	ip netns exec "$ns2" timeout 5 socat -u -4 TCP-LISTEN:8080,reuseaddr STDOUT > "${outfile}" &
 	server_pid=$!
 	sleep 0.2
 }
-- 
2.43.0

Re: [nf PATCH v2] selftests: netfilter: Avoid hanging ipvs.sh

[Pablo Neira Ayuso]

On Thu, Sep 19, 2024 at 02:40:00PM +0200, Phil Sutter wrote:
> If the client can't reach the server, the latter remains listening
> forever. Kill it after 5s of waiting.

This looks more similar to what I have seen.

I have to admit I am still learning the common idioms that are used in
selftest.

Applied, thanks.