From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: matttbe@kernel.org, fw@strlen.de, phil@nwl.cc
Subject: Re: [PATCH nf] netfilter: nf_tables: wait for rcu grace period on net_device removal
Date: Mon, 28 Oct 2024 16:23:32 +0100 [thread overview]
Message-ID: <Zx-sdKnimQmwGck9@calendula> (raw)
In-Reply-To: <20241028151351.19562-1-pablo@netfilter.org>
On Mon, Oct 28, 2024 at 04:13:51PM +0100, Pablo Neira Ayuso wrote:
> 8c873e219970 ("netfilter: core: free hooks with call_rcu") removed
> synchronize_net() call when unregistering basechain hook, however,
> net_device removal event handler for the NFPROTO_NETDEV was not updated
> to wait for RCU grace period.
>
> Note that 835b803377f5 ("netfilter: nf_tables_netdev: unregister hooks
> on net_device removal") does not remove basechain rules on device
> removal, it was just a bit later that I was hinted to remove rules on
> net_device removal, see 5ebe0b0eec9d ("netfilter: nf_tables: destroy
> basechain and rules on netdevice removal").
I have to scratch this patch, I am seeing an issue with it, sorry for
the noise.
prev parent reply other threads:[~2024-10-28 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 15:13 [PATCH nf] netfilter: nf_tables: wait for rcu grace period on net_device removal Pablo Neira Ayuso
2024-10-28 15:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zx-sdKnimQmwGck9@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=matttbe@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox