From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56CD31D1F7E
	for <netfilter-devel@vger.kernel.org>; Thu, 17 Oct 2024 08:10:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1729152619; cv=none; b=hsuvRuJI3ejL6EbyD6cORGipN5Fw2oA+Kd/tQaoPn0lSIbIHFmjaqZtUSyfW3JdjihfFoQHw32o7HNfcX3UAkjOUwsUG47pVjqqY7A8vFIbWQQFV896eAWRexysO92an9o5XUbTmcDa/SeVSluh9XQ4Po/AJssMuIz9M+/c33gE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1729152619; c=relaxed/simple;
	bh=Eov820XE1tPdw8V5BB509BYETfa/MSrNZrKF1wYWg8I=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=QLhhMwfJ16t6Vw2cw4/FY4OD+Y6/Hhukj5QGcj+KMnnJmEZ7cFWJUyDycGcTRV7Omxre0TMyNl9HZnoIH6bTIETCFCxu4uEZ5JQQvHlha7SsZAC9C557sQzPcIh+7W/hnL5EEBQZKSocj07eFVdPAIiC6BKaG2Uz7xF63yv/oi4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org
Received: from [78.30.37.63] (port=43254 helo=gnumonks.org)
	by ganesha.gnumonks.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pablo@gnumonks.org>)
	id 1t1La9-00EMV2-07; Thu, 17 Oct 2024 10:10:07 +0200
Date: Thu, 17 Oct 2024 10:10:03 +0200
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Cc: Duncan Roe <duncan_roe@optusnet.com.au>
Subject: Re: [PATCH libnftnl] include: refresh nf_tables.h copy
Message-ID: <ZxDGW1bmhBnl9FHN@calendula>
References: <20241010125858.1540-1-pablo@netfilter.org>
 <ZxCm45kYRQu77bWX@slk15.local.net>
Precedence: bulk
X-Mailing-List: netfilter-devel@vger.kernel.org
List-Id: <netfilter-devel.vger.kernel.org>
List-Subscribe: <mailto:netfilter-devel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netfilter-devel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZxCm45kYRQu77bWX@slk15.local.net>
X-Spam-Score: -1.9 (-)

Hi Duncan,

On Thu, Oct 17, 2024 at 04:55:47PM +1100, Duncan Roe wrote:
[...]
> Suggest a better patch would be to delete this file.
>
> linux/netfilter/nf_tables.h is generated by kernel `make headers_install`, as is
> linux/errno.h (required by errno.h) and asm/socket.h (required by sys/socket.h).
> 
> We don't cache linux/errno.h or asm/socket.h, so why cache
> linux/netfilter/nf_tables.h?

Please note that all libraries cache this file to facilitate the
compilation of the library with older kernel headers. This practice is
intentional and essential for ensuring compatibility and flexibility
in the compilation process.

Thanks.