Linux Netfilter development
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Jan Engelhardt <ej@inai.de>
Cc: netfilter-devel@vger.kernel.org,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	coreteam@netfilter.org
Subject: Re: [iptables PATCH] libxtables: Hide xtables_strtoul_base() symbol
Date: Thu, 7 Nov 2024 17:44:46 +0100	[thread overview]
Message-ID: <ZyzufuOtzaToGLv8@orbyte.nwl.cc> (raw)
In-Reply-To: <8361oqo4-qnss-089n-885s-nqqq6520r6r8@vanv.qr>

On Thu, Nov 07, 2024 at 05:43:10PM +0100, Jan Engelhardt wrote:
> 
> On Thursday 2024-11-07 17:12, Phil Sutter wrote:
> 
> >diff --git a/include/xtables_internal.h b/include/xtables_internal.h
> >new file mode 100644
> >index 0000000000000..a87a40cc8dae5
> >--- /dev/null
> >+++ b/include/xtables_internal.h
> >@@ -0,0 +1,7 @@
> >+#ifndef XTABLES_INTERNAL_H
> >+#define XTABLES_INTERNAL_H 1
> >+
> >+extern bool xtables_strtoul_base(const char *, char **, uintmax_t *,
> >+	uintmax_t, uintmax_t, unsigned int);
> >+
> >+#endif /* XTABLES_INTERNAL_H */
> 
> Don't we already have xshared.h for this?

That's iptables/xshared.h and it's not included outside of that
subfolder.

      reply	other threads:[~2024-11-07 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ZyzYApZKx79g8jqm@calendula>
2024-11-07 16:12 ` [iptables PATCH] libxtables: Hide xtables_strtoul_base() symbol Phil Sutter
2024-11-07 16:38   ` Pablo Neira Ayuso
2024-11-07 16:41     ` Phil Sutter
2024-11-07 16:43   ` Jan Engelhardt
2024-11-07 16:44     ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZyzufuOtzaToGLv8@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=coreteam@netfilter.org \
    --cc=ej@inai.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox