From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v4 0/5] netfilter: nf_tables: reduce set element transaction size
Date: Tue, 12 Nov 2024 19:42:24 +0100 [thread overview]
Message-ID: <ZzOhkNh58vkHW62c@calendula> (raw)
In-Reply-To: <20241107174415.4690-1-fw@strlen.de>
Hi Florian,
This series looks good to me.
Regarding 3/5, I don't see any fix or anything silly in this.
>nftables audit log format unfortunately leaks an implementation detail, the
>transaction log size, to userspace:
>
> table=t1 family=2 entries=4 op=nft_register_set
> ~~~~~~~~~
>
>This 'entries' key is the number of transactions that will be applied.
To my understanding, entries= is the number of entries that are either
added or updated in this transaction.
Before this patch, there was a 1:1 mapping between transaction and
elements, now this is not the case anymore.
If entries= exposes only the number of transactions, then this becomes
useless to userspace?
In iptables, it shows the number of entries in the table after the
update.
next prev parent reply other threads:[~2024-11-12 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 17:44 [PATCH nf-next v4 0/5] netfilter: nf_tables: reduce set element transaction size Florian Westphal
2024-11-07 17:44 ` [PATCH nf-next v4 1/5] netfilter: nf_tables: add nft_trans_commit_list_add_elem helper Florian Westphal
2024-11-07 17:44 ` [PATCH nf-next v4 2/5] netfilter: nf_tables: prepare for multiple elements in nft_trans_elem structure Florian Westphal
2024-11-07 17:44 ` [PATCH nf-next v4 3/5] netfilter: nf_tables: preemptive fix for audit selftest failure Florian Westphal
2024-11-07 17:44 ` [PATCH nf-next v4 4/5] netfilter: nf_tables: switch trans_elem to real flex array Florian Westphal
2024-11-13 10:15 ` Pablo Neira Ayuso
2024-11-13 11:04 ` Florian Westphal
2024-11-13 11:11 ` Pablo Neira Ayuso
2024-11-07 17:44 ` [PATCH nf-next v4 5/5] netfilter: nf_tables: allocate element update information dynamically Florian Westphal
2024-11-12 18:42 ` Pablo Neira Ayuso [this message]
2024-11-12 20:44 ` [PATCH nf-next v4 0/5] netfilter: nf_tables: reduce set element transaction size Florian Westphal
2024-11-13 10:19 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzOhkNh58vkHW62c@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox