From: Lance Yang <lance.yang@linux.dev>
To: Florian Westphal <fw@strlen.de>
Cc: pablo@netfilter.org, coreteam@netfilter.org, davem@davemloft.net,
Lance Yang <ioworker0@gmail.com>,
edumazet@google.com, horms@kernel.org, kadlec@netfilter.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, pabeni@redhat.com,
zi.li@linux.dev
Subject: Re: [PATCH v2 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid
Date: Wed, 28 May 2025 19:42:50 +0800 [thread overview]
Message-ID: <a2f5fb23-e57a-4a83-bb95-b5756df0e2d7@linux.dev> (raw)
In-Reply-To: <aDbt9Iw8G6A-tV9R@strlen.de>
Thanks for taking the time to review!
On 2025/5/28 19:05, Florian Westphal wrote:
> Lance Yang <ioworker0@gmail.com> wrote:
>> From: Lance Yang <lance.yang@linux.dev>
>>
>> When no logger is registered, nf_conntrack_log_invalid fails to log invalid
>> packets, leaving users unaware of actual invalid traffic. Improve this by
>> loading nf_log_syslog, similar to how 'iptables -I FORWARD 1 -m conntrack
>> --ctstate INVALID -j LOG' triggers it.
>
> Acked-by: Florian Westphal <fw@strlen.de>
Hmm... should this patch be backported to stable kernels? Without it,
nf_conntrack_log_invalid won't log invalid packets when no logger is
registered, causing unnecessary debugging effort ;)
Back then, I actually thought my machine wasn't seeing any invalid
packets... turns out they just weren't logged in dmesg :(
Thanks,
Lance
next prev parent reply other threads:[~2025-05-28 11:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 8:59 [PATCH v2 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid Lance Yang
2025-05-28 11:05 ` Florian Westphal
2025-05-28 11:42 ` Lance Yang [this message]
2025-05-30 3:10 ` Lance Yang
2025-07-14 12:05 ` Lance Yang
2025-07-24 12:24 ` Pablo Neira Ayuso
2025-07-24 12:48 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2f5fb23-e57a-4a83-bb95-b5756df0e2d7@linux.dev \
--to=lance.yang@linux.dev \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=ioworker0@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=zi.li@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).