From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>,
syzbot <syzbot+0502b00edac2a0680b61@syzkaller.appspotmail.com>
Cc: coreteam@netfilter.org, David Miller <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
LKML <linux-kernel@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
syzkaller-bugs@googlegroups.com
Subject: Re: WARNING in __proc_create
Date: Fri, 9 Mar 2018 14:56:08 -0800 [thread overview]
Message-ID: <a559bbb6-0db4-2b71-b363-792d88d7eef7@gmail.com> (raw)
In-Reply-To: <CAM_iQpV+PnGUXEKcSrF7u19NOeLLp0PhDW-DOkEfS+8pLnTgYw@mail.gmail.com>
On 03/09/2018 02:48 PM, Cong Wang wrote:
> On Fri, Mar 9, 2018 at 1:59 PM, syzbot
> <syzbot+0502b00edac2a0680b61@syzkaller.appspotmail.com> wrote:
>> Hello,
>>
>> syzbot hit the following crash on net-next commit
>> 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +0000)
>> Merge tag 'usercopy-v4.16-rc1' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
>>
>> So far this crash happened 12 times on net-next, upstream.
>> C reproducer is attached.
>> syzkaller reproducer is attached.
>> Raw console output is attached.
>> compiler: gcc (GCC) 7.1.1 20170620
>> .config is attached.
>>
>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>> Reported-by: syzbot+0502b00edac2a0680b61@syzkaller.appspotmail.com
>> It will help syzbot understand when the bug is fixed. See footer for
>> details.
>> If you forward the report, please keep this part and the footer.
>>
>> audit: type=1400 audit(1518223777.419:7): avc: denied { map } for
>> pid=4159 comm="syzkaller598581" path="/root/syzkaller598581546" dev="sda1"
>> ino=16481 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
>> tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
>> ------------[ cut here ]------------
>> name len 0
>> WARNING: CPU: 0 PID: 4159 at fs/proc/generic.c:354 __proc_create+0x696/0x880
>> fs/proc/generic.c:354
>
> We need to reject empty names.
>
I sent a patch a while back, but Pablo/Florian wanted more than that
simple fix.
We also need to filter special characters like '/'
Or maybe I am mixing with something else.
next prev parent reply other threads:[~2018-03-09 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 21:59 WARNING in __proc_create syzbot
2018-03-09 22:48 ` Cong Wang
2018-03-09 22:56 ` Eric Dumazet [this message]
2018-03-09 22:58 ` Eric Dumazet
2018-03-09 23:05 ` Cong Wang
2018-03-09 23:18 ` Florian Westphal
2018-03-09 23:21 ` Eric Dumazet
2018-03-09 23:32 ` Cong Wang
2018-03-09 23:42 ` Eric Dumazet
2018-03-09 23:02 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a559bbb6-0db4-2b71-b363-792d88d7eef7@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzbot+0502b00edac2a0680b61@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).