From: Arturo Borrero Gonzalez <arturo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 2/3] libnftables: reallocate definition of nft_print() and nft_gmp_print()
Date: Thu, 27 Jun 2019 12:59:43 +0200 [thread overview]
Message-ID: <a766c2a4-602f-19f1-24d5-be1f8cabe056@netfilter.org> (raw)
In-Reply-To: <156163261193.22035.5939540630503363251.stgit@endurance>
On 6/27/19 12:50 PM, Arturo Borrero Gonzalez wrote:
> They are not part of the libnftables library API, they are not public symbols,
> so it doesn't not make sense to have them there. Move the two functions to a
> different source file.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
> ---
> src/libnftables.c | 27 ---------------------------
> src/utils.c | 26 ++++++++++++++++++++++++++
> 2 files changed, 26 insertions(+), 27 deletions(-)
>
This patch is probably not required, it does not affect how visible the symbols
of the library are.
Drop it or apply it, I'm fine either way.
next prev parent reply other threads:[~2019-06-27 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 10:50 [nft PATCH 1/3] nft: use own allocation function Arturo Borrero Gonzalez
2019-06-27 10:50 ` [nft PATCH 2/3] libnftables: reallocate definition of nft_print() and nft_gmp_print() Arturo Borrero Gonzalez
2019-06-27 10:59 ` Arturo Borrero Gonzalez [this message]
2019-06-27 11:22 ` Florian Westphal
2019-06-27 12:20 ` Pablo Neira Ayuso
2019-06-27 10:50 ` [nft PATCH 3/3] libnftables: export public symbols only Arturo Borrero Gonzalez
2019-06-27 11:21 ` Florian Westphal
2019-06-27 11:20 ` [nft PATCH 1/3] nft: use own allocation function Florian Westphal
2019-06-27 12:19 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a766c2a4-602f-19f1-24d5-be1f8cabe056@netfilter.org \
--to=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).