From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH v2] utils: Add helpers for interface name wildcards
Date: Wed, 16 Jul 2025 11:44:59 +0200 [thread overview]
Message-ID: <aHd0mxVSp_cFcn16@strlen.de> (raw)
In-Reply-To: <20250715151526.14573-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> #include <string.h>
> #include <stdlib.h>
> +#include <libmnl/libmnl.h>
Why is this include needed?
> #include <libnftnl/common.h>
>
> #include "config.h"
> @@ -83,4 +84,7 @@ int nftnl_fprintf(FILE *fpconst, const void *obj, uint32_t cmd, uint32_t type,
> int nftnl_set_str_attr(const char **dptr, uint32_t *flags,
> uint16_t attr, const void *data, uint32_t data_len);
>
> +void mnl_attr_put_ifname(struct nlmsghdr *nlh, int attr, const char *ifname);
> +const char *mnl_attr_get_ifname(struct nlattr *attr);
> +
nftnl_attr_put_ifname, nftnl_attr_get_ifname?
Using mnl_ prefix seems wrong, that should be reserved for libmnl.
next prev parent reply other threads:[~2025-07-16 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 15:15 [libnftnl PATCH v2] utils: Add helpers for interface name wildcards Phil Sutter
2025-07-16 9:44 ` Florian Westphal [this message]
2025-07-16 10:01 ` Phil Sutter
2025-07-16 10:07 ` Florian Westphal
2025-07-16 10:11 ` Phil Sutter
2025-07-16 14:39 ` Pablo Neira Ayuso
2025-07-16 14:42 ` Pablo Neira Ayuso
2025-07-16 14:45 ` Pablo Neira Ayuso
2025-07-16 16:12 ` Phil Sutter
2025-07-16 14:38 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHd0mxVSp_cFcn16@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).