From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 6/6] Makefile: Enable support for 'make check'
Date: Thu, 28 Aug 2025 12:38:48 +0200 [thread overview]
Message-ID: <aLAxuEXDU1IpqT8G@orbyte.nwl.cc> (raw)
In-Reply-To: <aK-P6gvGB-sSKYj8@calendula>
Hi,
On Thu, Aug 28, 2025 at 01:08:26AM +0200, Pablo Neira Ayuso wrote:
[...]
> 'make testrun' sounds nicer than my run-it-all shell script proposal,
> it would be nice to have a short summary at the test run not to scroll
> up to find each individual test result. And I think 'make testrun'
> should continue on errors so it is also useful for testing patches
> under development.
After a second look (and with Jan's distcheck fix patch in mind) I found
a way to distinguish between 'make distcheck' calling 'make check' and a
user doing so. This way we can use 'make check' as it is intended and
leverage automake's test suite integration while at the same time keep
'make distcheck' untouched.
I'll send a new series once I have collected what's really needed for
it.
Cheers, Phil
prev parent reply other threads:[~2025-08-28 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 16:10 [nft PATCH 0/6] Run all test suites via 'make check' Phil Sutter
2025-08-01 16:11 ` [nft PATCH 1/6] tests: Prepare exit codes for automake Phil Sutter
2025-08-01 16:11 ` [nft PATCH 2/6] tests: monitor: Support running all tests in one go Phil Sutter
2025-08-01 16:11 ` [nft PATCH 3/6] tests: py: Set default options based on RUN_FULL_TESTSUITE Phil Sutter
2025-08-01 16:11 ` [nft PATCH 4/6] tests: json_echo: Skip if run as non-root Phil Sutter
2025-08-01 16:11 ` [nft PATCH 5/6] tests: shell: Skip packetpath/nat_ftp in fake root env Phil Sutter
2025-08-01 16:11 ` [nft PATCH 6/6] Makefile: Enable support for 'make check' Phil Sutter
2025-08-06 17:05 ` Pablo Neira Ayuso
2025-08-07 11:51 ` Phil Sutter
2025-08-07 12:14 ` Pablo Neira Ayuso
2025-08-07 13:04 ` Phil Sutter
2025-08-27 23:08 ` Pablo Neira Ayuso
2025-08-28 10:38 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLAxuEXDU1IpqT8G@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).