Re: [nft PATCH v4 0/8] Run all test suites via 'make check'

[Phil Sutter <phil@nwl.cc>]

On Thu, Sep 04, 2025 at 05:24:46PM +0200, Phil Sutter wrote:
> Help me (and maybe others) to not occasionally forget to run this or
> that test suite in this or that mode:
> 
> Have test suites execute all variants by default (patches 1 and 2), make
> sure their exit codes match Automake expectations (patch 3) and register
> them with Automake (patch 8). Also fix for running 'make check' as
> non-root (patches 4 and 5) and calling build test suite from outside its
> directory (patch 6).
> 
> There is a "funny" problem with build test suite calling 'make
> distcheck' which behaves differently under the environment polluted by
> the calling 'make check' invocation, details in patch 7.
> 
> Changes since v3:
> - Applied the initial monitor test suite enhancements already
> - gitignore generated logs and reports
> - New patch 7
> 
> Changes since v2:
> - Drop the need for RUN_FULL_TESTSUITE env var by making the "all
>   variants" mode the default in all test suites
> - Implement JSON echo testing into monitor test suite, stored JSON
>   output matches echo output after minor adjustment
> 
> Changes since v1:
> - Also integrate build test suite
> - Populate TESTS variable only for non-distcheck builds, so 'make
>   distcheck' does not run any test suite
> 
> Phil Sutter (8):
>   tests: monitor: Excercise all syntaxes and variants by default
>   tests: py: Enable JSON and JSON schema by default
>   tests: Prepare exit codes for automake
>   tests: json_echo: Skip if run as non-root
>   tests: shell: Skip packetpath/nat_ftp in fake root env
>   tests: build: Do not assume caller's CWD
>   tests: build: Avoid a recursive 'make check' run
>   Makefile: Enable support for 'make check'

Series applied. I will follow up with the promised refactoring of
rule_add() function to finally align cmdline options with other test
suite runners.