From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] build: disable --with-unitdir by default
Date: Thu, 25 Sep 2025 23:43:30 +0200 [thread overview]
Message-ID: <aNW3gjiVZ8GuwH7x@calendula> (raw)
In-Reply-To: <20250829154350.GE3204340@azazel.net>
On Fri, Aug 29, 2025 at 04:43:50PM +0100, Jeremy Sowden wrote:
> On 2025-08-27, at 16:46:15 +0200, Pablo Neira Ayuso wrote:
> > Cc'ing Phil, Jan.
> >
> > Excuse me my terse proposal description.
> >
> > Extension: This is an alternative patch to disable --with-unitdir by
> > default, to address distcheck issue.
> >
> > I wonder also if this is a more conservative approach, this should
> > integrate more seamlessly into existing pipelines while allowing
> > distributors to opt-in to use this.
> >
> > But maybe I'm worrying too much and it is just fine to change defaults
> > for downstream packagers.
>
> The upshot of this is that the service file is not installed by default, but
> the related man-page and the example main.nft still are. Gueesing this is an
> oversight? If so, I will send a patch.
Yes, it is an oversight. Thanks.
prev parent reply other threads:[~2025-09-25 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 14:02 [PATCH nft] build: disable --with-unitdir by default Pablo Neira Ayuso
2025-08-27 14:46 ` Pablo Neira Ayuso
2025-08-27 20:36 ` Pablo Neira Ayuso
2025-08-27 20:38 ` Phil Sutter
2025-08-29 15:43 ` Jeremy Sowden
2025-09-25 21:43 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNW3gjiVZ8GuwH7x@calendula \
--to=pablo@netfilter.org \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox