Re: [libnftnl PATCH] utils: Drop asterisk from end of NFTA_DEVICE_PREFIX strings

[Phil Sutter <phil@nwl.cc>]

On Wed, Oct 15, 2025 at 12:33:44AM +0200, Pablo Neira Ayuso wrote:
> On Wed, Oct 08, 2025 at 12:05:53AM +0200, Phil Sutter wrote:
> > Hi Pablo,
> > 
> > On Tue, Oct 07, 2025 at 11:42:05PM +0200, Pablo Neira Ayuso wrote:
> > > On Tue, Oct 07, 2025 at 05:58:26PM +0200, Phil Sutter wrote:
> > > > The asterisk left in place becomes part of the prefix by accident and is thus
> > > > both included when matching interface names as well as dumped back to user
> > > > space.
> > > > 
> > > > Fixes: f30eae26d813e ("utils: Add helpers for interface name wildcards")
> > > > Signed-off-by: Phil Sutter <phil@nwl.cc>
> > > > ---
> > > > This code is currently unused by nftables at least since it builds the
> > > > netlink message itself.
> > > 
> > > This was moved to nftables, and no release was made to include it?
> > > Would it possible to remove it from libnftnl?
> > 
> > The code layout is a bit inconsistent in this regard: While nftables
> > does the serialization itself (to record offsets for extack), it relies
> > upon libnftnl to perform the deserialization. Therefore parts of the
> > wildcard interface feature will have to be spread over the two projects.
> > And since this is the case, I decided to keep libnftnl's serialization
> > code "maintained" in this regard, i.e. enable it to perform the netlink
> > message building for wildcard interface names as well even though there
> > is no known user for it.
> > 
> > I'd prefer to keep it, also because I see us eventually returning to
> > libnftnl's serialization code once there is a mechanism to extract the
> > offsets for extack. You have the last word though (as always)! :)
> 
> LGTM, thanks for explaining.

Patch applied, thanks!