From: Florian Westphal <fw@strlen.de>
To: Andrii Melnychenko <a.melnychenko@vyos.io>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
kadlec@netfilter.org, phil@nwl.cc, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] nft_ct: Added nfct_seqadj_ext_add() for NAT'ed conntrack.
Date: Fri, 24 Oct 2025 14:58:13 +0200 [thread overview]
Message-ID: <aPt35eDPqjUAuG1U@strlen.de> (raw)
In-Reply-To: <CANhDHd_W=FQkm0u3ZBSE4-RQpGQcXUqKwJRDj7e9anPbv8Djrw@mail.gmail.com>
Andrii Melnychenko <a.melnychenko@vyos.io> wrote:
> Client has to connect to the router (192.168.100.2 -> 192.168.100.2),
> while the FTP server would receive the connection from the client
> (192.168.100.2 -> 192.168.33.2).
> So the connection hits SNAT when it's already established and confirmed.
>
> > This sets up snat which calls nf_nat_setup_info which adds the
> > seqadj extension.
>
> So, we still need to add seqadj allocation for DNAT.
> I will propose a new patch v4 with `regs->verdict.code = NF_DROP;`.
Yes, just resend your previous patch with the DROP added to force
rexmit rather than ending up with a non-working/stuck connection.
> And later, I can provide a new ruleset for tests in `nft_ftp` for `nftables`.
Thank you.
> Any suggestions?
You can send the bug fix now and followup with a different config later,
you can just extend the existing test case or, if you think your scenario
differs too much, add a new one.
next prev parent reply other threads:[~2025-10-24 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 13:39 [PATCH v3 0/1] nf_conntrack_ftp: Added nfct_seqadj_ext_add() Andrii Melnychenko
2025-10-21 13:39 ` [PATCH v3 1/1] nft_ct: Added nfct_seqadj_ext_add() for NAT'ed conntrack Andrii Melnychenko
2025-10-21 14:34 ` Florian Westphal
2025-10-21 16:24 ` Andrii Melnychenko
2025-10-21 16:34 ` Florian Westphal
2025-10-22 0:11 ` Pablo Neira Ayuso
2025-10-22 11:14 ` Florian Westphal
2025-10-22 13:01 ` Andrii Melnychenko
2025-10-23 12:28 ` Andrii Melnychenko
2025-10-23 12:42 ` Florian Westphal
2025-10-24 12:26 ` Andrii Melnychenko
2025-10-24 12:58 ` Florian Westphal [this message]
2025-10-21 14:35 ` [PATCH v3 0/1] nf_conntrack_ftp: Added nfct_seqadj_ext_add() Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPt35eDPqjUAuG1U@strlen.de \
--to=fw@strlen.de \
--cc=a.melnychenko@vyos.io \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).