From: Florian Westphal <fw@strlen.de>
To: Antonio Ojea <aojea@google.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_ct: enable labels for get case too
Date: Fri, 24 Oct 2025 14:55:11 +0200 [thread overview]
Message-ID: <aPt3L9LboWOsalSv@strlen.de> (raw)
In-Reply-To: <CAAdXToT6ZfaP3oxuYdVK9PWwWwuyHeaRuJdOX9sXoVenhtnAmg@mail.gmail.com>
Antonio Ojea <aojea@google.com> wrote:
> Hi Florian, I'm trying to add a kselftest
Thanks!
> but it seems the conntrack
> tool fails to add the label if the /etc/xtables/connlabel.conf file
> does not exist. This is the behavior I'm observing:
> - conntrack -U:
> - fails if the file does not exist
> - works if the file exists, but if the entry does not exist in the
> file the tool throws an error but the label is added
> - conntrack -L -o label
> - does not output the label if the file does not exist or is empty.
> - if the file exists and the ct entry label exists in the file, then
> it's correctly displayed in conntrack -L
> - if the file exists but the label is not present in the file, the
> output has a labels statement but is empty
Hmm, this isn't ideal, it should resort to a hexdump in that case
(on -L), needs a fix.
> Can you give me advice on how to proceed?
Best advice I can give is to check if conntrack tool supports
--labelmap option (not in any released version, added in June this
year).
And then add a custom temporary config file via 'mktemp' + feed that
file to conntrack.
prev parent reply other threads:[~2025-10-24 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 12:09 [PATCH nf] netfilter: nft_ct: enable labels for get case too Florian Westphal
2025-10-24 12:33 ` Antonio Ojea
2025-10-24 12:55 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPt3L9LboWOsalSv@strlen.de \
--to=fw@strlen.de \
--cc=aojea@google.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).