From: Phil Sutter <phil@nwl.cc>
To: Alexandre Knecht <knecht.alexandre@gmail.com>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH nf v3 2/2] doc: clarify JSON rule positioning with handle field
Date: Thu, 6 Nov 2025 11:36:44 +0100 [thread overview]
Message-ID: <aQx6PEYRIv68lUAj@orbyte.nwl.cc> (raw)
In-Reply-To: <20251106091609.220296-1-knecht.alexandre@gmail.com>
On Thu, Nov 06, 2025 at 10:16:09AM +0100, Alexandre Knecht wrote:
> The existing documentation briefly mentioned that the handle field can be
> used for positioning, but the behavior was ambiguous. This commit clarifies:
>
> - ADD with handle: inserts rule AFTER the specified handle
> - INSERT with handle: inserts rule BEFORE the specified handle
> - Multiple rules added at the same handle are positioned relative to the
> original rule, not to previously inserted rules
> - Explicit commands (with command wrapper) use handle for positioning
> - Implicit commands (without command wrapper, used in export/import)
> ignore handle for portability
>
> This clarification helps users understand the correct behavior and avoid
> confusion when using the JSON API for rule management.
>
> Signed-off-by: Alexandre Knecht <knecht.alexandre@gmail.com>
Acked-by: Phil Sutter <phil@nwl.cc>
But please let's wait with this until the related code fix is ready.
Thanks, Phil
prev parent reply other threads:[~2025-11-06 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 9:16 [PATCH nf v3 2/2] doc: clarify JSON rule positioning with handle field Alexandre Knecht
2025-11-06 10:36 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQx6PEYRIv68lUAj@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=knecht.alexandre@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).