From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23FA043D4FE for ; Tue, 20 Jan 2026 14:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919714; cv=none; b=ejqA9UgIgFcALk6fC90bc72F3t7yKSB2Giw0C7aPyrAG8HIRyznEE5vP74ppzargTb3D7eXE5w/zxVjgjZOpBGezvP9VhbIU7EdwCtCfin/Q10vJxZHzUX8wqmU2im+BJ+svCwtGQ5nznebrrhkP2tUVWcuza3OKuv3/WD9kuzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768919714; c=relaxed/simple; bh=Aca5frLAx+PtJhq6l11i0Pm1ZvWrVDm4h/yHuPrIsEM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MceFdlYaVYnBs42+dqu0UmPaXPs4o89xcSspmKIhbkt8+5KloRTqxuflH8In47/dLlbp345wNuB9CWei9q1WlywhvWT8vIkOFUNCQs4bSdyamKAXce+KpV9bjeRcqZOAuNKHYE3TyVOXU2cvFQkQFOLTh9HjPNAwq6GIUXC8DFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id 59A9060260; Tue, 20 Jan 2026 15:35:05 +0100 (CET) Date: Tue, 20 Jan 2026 15:35:05 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH 6/6] scanner: Introduce SCANSTATE_RATE Message-ID: References: <20251209164541.13425-1-phil@nwl.cc> <20251209164541.13425-7-phil@nwl.cc> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251209164541.13425-7-phil@nwl.cc> Phil Sutter wrote: > This is a first exclusive start condition, i.e. one which rejects > unscoped tokens. When tokenizing, flex all too easily falls back into > treating something as STRING when it could be split into tokens instead. > Via an exclusive start condition, the string-fallback can be disabled as > needed. > > With rates in typical formatting /, > tokenizer result depended on whitespace placement. SCANSTATE_RATE forces > flex to split the string into tokens and fall back to JUNK upon failure. > For this to work, tokens which shall still be recognized must be enabled > in SCANSTATE_RATE (or all scopes denoted by '*'). This includes any > tokens possibly following SCANSTATE_RATE to please the parser's > lookahead behaviour. Series: Reviewed-by: Florian Westphal