From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 6/6] scanner: Introduce SCANSTATE_RATE
Date: Tue, 20 Jan 2026 17:28:37 +0100 [thread overview]
Message-ID: <aW-tNd_HhE7SvU6c@orbyte.nwl.cc> (raw)
In-Reply-To: <aW-SicaUzUULQFv9@strlen.de>
On Tue, Jan 20, 2026 at 03:35:05PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > This is a first exclusive start condition, i.e. one which rejects
> > unscoped tokens. When tokenizing, flex all too easily falls back into
> > treating something as STRING when it could be split into tokens instead.
> > Via an exclusive start condition, the string-fallback can be disabled as
> > needed.
> >
> > With rates in typical formatting <NUM><bytes-unit>/<time-unit>,
> > tokenizer result depended on whitespace placement. SCANSTATE_RATE forces
> > flex to split the string into tokens and fall back to JUNK upon failure.
> > For this to work, tokens which shall still be recognized must be enabled
> > in SCANSTATE_RATE (or all scopes denoted by '*'). This includes any
> > tokens possibly following SCANSTATE_RATE to please the parser's
> > lookahead behaviour.
>
> Series:
> Reviewed-by: Florian Westphal <fw@strlen.de>
Series applied, thanks!
prev parent reply other threads:[~2026-01-20 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 16:45 [nft PATCH 0/6] parser_bison: Less STRING more tokens Phil Sutter
2025-12-09 16:45 ` [nft PATCH 1/6] parser_bison: Introduce tokens for monitor events Phil Sutter
2025-12-09 16:45 ` [nft PATCH 2/6] parser_bison: Introduce tokens for chain types Phil Sutter
2025-12-09 16:45 ` [nft PATCH 3/6] parser_bison: Introduce tokens for osf ttl values Phil Sutter
2025-12-09 16:45 ` [nft PATCH 4/6] parser_bison: Introduce tokens for log levels Phil Sutter
2025-12-09 16:45 ` [nft PATCH 5/6] parser_bison: Introduce bytes_unit Phil Sutter
2025-12-09 16:45 ` [nft PATCH 6/6] scanner: Introduce SCANSTATE_RATE Phil Sutter
2026-01-20 14:35 ` Florian Westphal
2026-01-20 16:28 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-tNd_HhE7SvU6c@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox