Re: [PATCH nf-next,v1 1/3] netfilter: nf_tables: add .abort_skip_removal flag for set types

[Florian Westphal <fw@strlen.de>]

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> The pipapo set backend is the only user of the .abort interface so far.
> To speed up pipapo abort path, removals are skipped.
> 
> The follow up patch updates the rbtree to use to build an array of
> ordered elements, then use binary search. This needs a new .abort
> interface but, unlike pipapo, it also need to undo/remove elements.
> 
> Add a flag and use it from the pipapo set backend.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
>  include/net/netfilter/nf_tables.h | 1 +
>  net/netfilter/nf_tables_api.c     | 2 +-
>  net/netfilter/nft_set_pipapo.c    | 2 ++
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
> index fab7dc73f738..21af1a2a6d3d 100644
> --- a/include/net/netfilter/nf_tables.h
> +++ b/include/net/netfilter/nf_tables.h
> @@ -509,6 +509,7 @@ struct nft_set_ops {
>  						   const struct nft_set *set);
>  	void				(*gc_init)(const struct nft_set *set);
>  
> +	bool				abort_skip_removal;
>  	unsigned int			elemsize;
>  };
>  

This gives kdoc warning:

Warning: include/net/netfilter/nf_tables.h:513 struct member 'abort_skip_removal' not described in 'nft_set_ops'