Linux Netfilter development
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Alexandre Knecht <knecht.alexandre@gmail.com>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH v6 0/3] parser_json: support handle for rule positioning
Date: Tue, 20 Jan 2026 23:55:49 +0100	[thread overview]
Message-ID: <aXAH9Zf_5z-gbP7A@orbyte.nwl.cc> (raw)
In-Reply-To: <20260120195303.1987192-1-knecht.alexandre@gmail.com>

On Tue, Jan 20, 2026 at 08:53:00PM +0100, Alexandre Knecht wrote:
> This patch series enables handle-based rule positioning for JSON
> add/insert commands.
> 
> Changes since v5:
> - Merged nested if-conditionals, sorted expressions cheap to expensive
>   (Phil feedback)
> - Use Reverse Christmas Tree notation for variable declarations
>   (Phil feedback)
> - Test 0007: Use $DIFF to verify ruleset state after ADD operations
>   instead of just checking command success (Phil feedback)
> 
> Changes since v4:
> - CTX_F_EXPR_MASK now uses inverse mask (UINT32_MAX & ~(...)) as
>   suggested by Phil, for future-proof expression flag filtering
> - Removed nested block in json_parse_cmd(), variables declared at
>   function start per project style (Phil/Florian feedback)
> - Test 0007: Removed redundant insert position check (covered by 0008),
>   replaced grep|grep|awk with single sed call
> - Test 0008: Added test for insert without handle, added test for
>   multiple commands in single transaction, fixed error message typo
> - Added .json-nft dump files for both tests
> 
> All JSON tests pass. check-tree.sh shows no new errors.
> 
> Alexandre Knecht (3):
>   parser_json: support handle for rule positioning in explicit JSON
>     format
>   tests: shell: add JSON test for all object types
>   tests: shell: add JSON test for handle-based rule positioning

Series applied, thanks!

I added a small fix for tests/json_echo test suite which broke due to a
leftover handle in an add rule command.

Cheers, Phil

      parent reply	other threads:[~2026-01-20 22:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 19:53 [PATCH v6 0/3] parser_json: support handle for rule positioning Alexandre Knecht
2026-01-20 19:53 ` [PATCH v6 1/3] parser_json: support handle for rule positioning in explicit JSON format Alexandre Knecht
2026-01-20 19:53 ` [PATCH v6 2/3] tests: shell: add JSON test for all object types Alexandre Knecht
2026-01-20 19:53 ` [PATCH v6 3/3] tests: shell: add JSON test for handle-based rule positioning Alexandre Knecht
2026-01-20 22:55 ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXAH9Zf_5z-gbP7A@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=knecht.alexandre@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox