public inbox for netfilter-devel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] Makefile: Set PKG_CONFIG_PATH env for 'make check'
Date: Thu, 5 Feb 2026 02:32:48 +0100	[thread overview]
Message-ID: <aYPzQOgGxpacVYMV@chamomile> (raw)
In-Reply-To: <20260127221657.28148-1-phil@nwl.cc>

On Tue, Jan 27, 2026 at 11:15:58PM +0100, Phil Sutter wrote:
> When building nftables git HEAD, I use a script which also builds libmnl
> and libnftnl in their respective repositories and populates
> PKG_CONFIG_PATH variable so nftables is linked against them instead of
> host libraries. This is mandatory as host-installed libraries are
> chronically outdated and linking against them would fail.

How do you use this?

> Same situation exists with build test suite. Luckily the PKG_CONFIG_PATH
> variable value used to build the project is cached in Makefiles and
> Automake supports populating test runners' environment.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> Pablo: Could you please confirm this does not break your workflow? I
> recall you relied upon build test suite while it never passed for me due
> to the reasons described above.

Just run `make distcheck' or tests/build/ to check, I think that
should be enough.

> ---
>  Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index b134330d5ca22..18af82a927dc0 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -450,6 +450,7 @@ tools/nftables.service: tools/nftables.service.in ${top_builddir}/config.status
>  endif
>  
>  if !BUILD_DISTCHECK
> +AM_TESTS_ENVIRONMENT = PKG_CONFIG_PATH=$(PKG_CONFIG_PATH)
>  TESTS = tests/build/run-tests.sh \
>  	tests/json_echo/run-test.py \
>  	tests/monitor/run-tests.sh \
> -- 
> 2.51.0
> 

  reply	other threads:[~2026-02-05  1:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 22:15 [nft PATCH] Makefile: Set PKG_CONFIG_PATH env for 'make check' Phil Sutter
2026-02-05  1:32 ` Pablo Neira Ayuso [this message]
2026-02-05 14:24   ` Phil Sutter
2026-02-05 14:27     ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYPzQOgGxpacVYMV@chamomile \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox