From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 0/4] Inspect and improve test suite code coverage
Date: Thu, 5 Feb 2026 02:35:57 +0100 [thread overview]
Message-ID: <aYPz_fmbjh5qjM30@chamomile> (raw)
In-Reply-To: <20260127222916.31806-1-phil@nwl.cc>
On Tue, Jan 27, 2026 at 11:29:12PM +0100, Phil Sutter wrote:
> While inspecting the test suites' code coverage using --coverage gcc
> option and gcov(r) for analysis, I noticed that 'nft monitor' processes
> did not influence the stats at all. It appears that a process receiving
> SIGTERM or SIGINT (via kill or ctrl-c) does not dump profiling data at
> exit. Installing a signal handler for those signals which calls exit()
> resolves this, so patch 1 of this series implements --enable-profiling
> into configure which also conditionally enables said signal handler.
>
> Patches 2 and 4 fix for zero test coverage of src/nftrace.c and
> src/xt.c, bumping stats to ~90% for both.
>
> Patch 3 fixes for ignored comment matches in translated iptables-nft
> rules. This is required for patch 4 which uses a comment match to check
> whether nft is built with translation support.
Apart from the aforementioned nitpick, series LGTM.
> Phil Sutter (4):
> configure: Implement --enable-profiling option
> tests: shell: Add a simple test for nftrace
> xt: Print comment match data as well
> tests: shell: Add a basic test for src/xt.c
>
> .gitignore | 5 +
> Makefile.am | 16 +++
> configure.ac | 7 ++
> src/main.c | 30 +++++
> src/xt.c | 6 +-
> tests/shell/features/xtables_xlate.sh | 21 ++++
> tests/shell/testcases/parsing/compat_xlate | 135 +++++++++++++++++++++
> tests/shell/testcases/trace/0001simple | 85 +++++++++++++
> 8 files changed, 304 insertions(+), 1 deletion(-)
> create mode 100755 tests/shell/features/xtables_xlate.sh
> create mode 100755 tests/shell/testcases/parsing/compat_xlate
> create mode 100755 tests/shell/testcases/trace/0001simple
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-02-05 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 22:29 [nft PATCH 0/4] Inspect and improve test suite code coverage Phil Sutter
2026-01-27 22:29 ` [nft PATCH 1/4] configure: Implement --enable-profiling option Phil Sutter
2026-02-05 1:29 ` Pablo Neira Ayuso
2026-01-27 22:29 ` [nft PATCH 2/4] tests: shell: Add a simple test for nftrace Phil Sutter
2026-01-27 22:29 ` [nft PATCH 3/4] xt: Print comment match data as well Phil Sutter
2026-02-05 1:35 ` Pablo Neira Ayuso
2026-02-05 13:29 ` Phil Sutter
2026-01-27 22:29 ` [nft PATCH 4/4] tests: shell: Add a basic test for src/xt.c Phil Sutter
2026-02-05 1:35 ` Pablo Neira Ayuso [this message]
2026-02-05 13:30 ` [nft PATCH 0/4] Inspect and improve test suite code coverage Phil Sutter
2026-02-05 15:21 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYPz_fmbjh5qjM30@chamomile \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox