From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9034A39E16A for ; Sat, 7 Mar 2026 13:06:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772888787; cv=none; b=FCWsnYF5xoUKwDzVnmk6kFFZuDRrcTnjwqMDGyaMMHZIk3rXmd89CXoUVPdNTe94GbztA6wGWl+RLAqU4SkfPatpKYgiIWxhu4+Kcgvs1gSnf1qzOJz2guzU39Iyvd+5U5aEZYze1HwUd/bCG+FGVypkZwkTGnq9sRj2mqXuBsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772888787; c=relaxed/simple; bh=74LBSmSfxwe36Fugw3zWrJ8SzGieG9C3xCU5xZslyuc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o3qCC9Nf2UPcEY5XbIFvZKCFxCal+A91JQeEQzlVxfDS33UJcMzio5mgRJgM7olf4c6fsyU+msCiIUXB/MIzxgQUajXBoLnVBtfmnTUYvX47zd1ks5biG7YeJy9DuhWhYC+MQr4iDHoDbjl9aX9A0/rm/2XmyG/FyiGDdeXtbvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id 9850B6077F; Sat, 07 Mar 2026 14:06:23 +0100 (CET) Date: Sat, 7 Mar 2026 14:06:23 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, carges@cloudflare.com Subject: Re: [PATCH nf,v2] netfilter: nft_set_rbtree: allocate same array size on updates Message-ID: References: <20260307001124.2897063-1-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Pablo Neira Ayuso wrote: > There is also set->ndeact that provides a hint on deactivated > elements. Oh, right, I fogot about that. So we even have an estimate of how many elements will disappear. > > So yes, there are smarter things that can be done here, but as for > this patch, my initial approach in this fix series was intentionally > simple. Sure, its better to use a simple patch for nf, rest can be expiremented with in nf-next, I did not want to hold up this patch and I intend to pick it up for nf.