From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18B012E1746 for ; Sat, 7 Mar 2026 17:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772904138; cv=none; b=NyQYqSfSiVVb+aIfKQLJ5+Fyvhsav5QcLqXj3mThyMLVMDEx3bbQNP9+072y1pOQnXqcj+QL9trkMuxRzkGbRhznXq3N9ZPuRlKN3HTOYKrQS7RGQUN94gQfmPZEpYwfuY1vsxM8WGu8cPntGYwcwLOti6zwGBiLh7WlNrTPJPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772904138; c=relaxed/simple; bh=b6dFSBwjZmzAufzl6/7jamXsse0LiQu2zuQz7VC6jM8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ErTa2KuBMocsQVvvUliDY3ZFtGksQqSzRv6JyrcRWd0K1Je+hjvGQ6GXfbp4kYk87T/uV5mP5FrfNiz+s0ziiL9AU9yoy/q8aYJ1gAntBUWSusE3PdeuvjITfZH808HAwHv/gjNojdmV+qY7XBxPry4dkcd29WN9+weSUZXaYY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UEhUdOeb; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UEhUdOeb" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c6dd5b01e14so3587941a12.0 for ; Sat, 07 Mar 2026 09:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772904135; x=1773508935; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=9APm84bWzD+gvTHG8pYZTCvzYx0lMSC2tah5Xx/NvoA=; b=UEhUdOebA4fnEAEQCtNPQBiDCbaYBdttIB/4qh81KPWDct6hqwL/b3LML+7bF3tKVf L/PLPc1SQMqYfdS8idb2zmyXgn1oiYO2EYuJCXLXIrLJeR3JOpxOb2EmPdjmSPtk/NMV wgV+Zfb2cvNnuTFdxoDZ++Yj8xFsX0EXCLn9OP2kOgoab0LtGs3VG/j21IN/HaS+OBwl zmiM7xYKd287aDoxXY2prqClHexQIzIIEdrWsl8AblEIaKlotgVXMRfCmo9bwg67F25E 6Vws05pLfASK3OkWNC/Ti1dlFcfSznChAGS3UcYqb/ibeGCCvtMAnEDxeDiJ/fplANg2 hZAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772904135; x=1773508935; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9APm84bWzD+gvTHG8pYZTCvzYx0lMSC2tah5Xx/NvoA=; b=q653/1yXetR4X/ff7ejtZPCFWT0pMKK5EprzipSFoywg5cxTcLC5tF/fBn0ybk4nE/ et7H28FraC3wrEt7LWdpXWbNaZYRVXH0fsgiqg3Au6wF45r/gQ4x4yCVFf1bjjM1hnYY s3cuBhrkBt0KR4uiNYQPmAwzCKZgxk3WRjd6mjluFaAnUhYHcJR4PNj8OI1W6io7WO/p BjQVgLh5Xqx05qkry6zcNosQjnfTWGtfprijHPTWsocA7WEjHALV3fp/swpQU6jkfMpV nUZD6HxTV6JPDZNUZr/K1kutlVFgPfeXwbYn/2upZP/E8JVP1zuknhp8ndW58ZtjDw1U mULg== X-Gm-Message-State: AOJu0YzqSkUNCArQ8ts3sv9xz5B9wzULBW7916QJdsCKJ4tODjnl+4SA D9HsM9+HcdCt2OXba+DOcNjpw/BNqUwANe/CoFdjjkPP1/wFqdhkGecudY0D+Q== X-Gm-Gg: ATEYQzwYm6NoKcETZ1Oxdfp30Xs6au/BRb8HEbf1+jRAyji4FBWOAw/Ru5ZyxoXiAAB mh9eJiEzshUXc9vS0j99WwmJuolX6s1qLvMcH6mSy5XYbihJ8Tn5gs4Mxg6lYn45uDAM+ZmHXUq cViBPK085P8zucgHaHX9JhWsPtHoRxh6Y02a3678V1jz2I+QJhITqevTYjLDWBp/MLRbt8QNIof 6VVZ6xzcZlVuNg0SBshsUJuTDVrv9pXhDQS96rae5NYvM/gI7AXDEEt01+Q1rckNbguhqbbQ1zm 17U/0WIOwovusI9uwsfEJ7onzResQ9NCzF7uiQ5u0xr9yBtJX0RRP61WNh1FBr+AlaZun5uKMJp 0zcptv0zxTP1DAWY7Mdkd95rhEtowqXMUkK8tniIV8uJDYsOUIoSbIpo1kdgU6Q2upkzTDRsrV6 R81c8DUKd2jt0PfqkgN+aFxZ1xrXVxzJY01kspg5+ujg== X-Received: by 2002:a05:6300:6702:b0:398:7982:8208 with SMTP id adf61e73a8af0-39879828268mr1099309637.1.1772904135440; Sat, 07 Mar 2026 09:22:15 -0800 (PST) Received: from v4bel ([58.123.110.97]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e170ee4sm4789742a12.21.2026.03.07.09.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 09:22:15 -0800 (PST) Date: Sun, 8 Mar 2026 02:22:11 +0900 From: Hyunwoo Kim To: pablo@netfilter.org, fw@strlen.de, phil@nwl.cc, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, imv4bel@gmail.com Subject: [PATCH net] netfilter: ctnetlink: validate CTA_EXPECT_NAT_DIR to prevent OOB access Message-ID: Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ctnetlink_parse_expect_nat() assigns the user-supplied CTA_EXPECT_NAT_DIR value directly to exp->dir without validating that it is within the valid range (0 to IP_CT_DIR_MAX-1). When nf_nat_sip_expected() later uses exp->dir as an index into ct->master->tuplehash[], an out-of-bounds array access occurs. For example, with exp->dir = 100, the access at ct->master->tuplehash[100] reads 5600 bytes past the start of a 320-byte nf_conn object, causing a slab-out-of-bounds read confirmed by UBSAN. Validate exp->dir against IP_CT_DIR_MAX before accepting it. UBSAN report: [ 1.411419] UBSAN: array-index-out-of-bounds in net/netfilter/nf_nat_sip.c:361:31 [ 1.412133] index 100 is out of range for type 'nf_conntrack_tuple_hash [2]' [ 1.412365] CPU: 0 UID: 0 PID: 131 Comm: poc_exp_dir Not tainted 7.0.0-rc2+ #8 PREEMPTLAZY [ 1.412368] Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 1.412370] Call Trace: [ 1.412374] [ 1.412375] dump_stack_lvl+0x64/0x80 [ 1.412388] __ubsan_handle_out_of_bounds+0xc9/0x100 [ 1.412398] nf_nat_sip_expected+0x4b9/0x4d0 [ 1.412405] ? __pfx_nf_nat_sip_expected+0x10/0x10 [ 1.412406] ? __asan_memset+0x23/0x50 [ 1.412413] ? nf_ct_ext_add+0x147/0x200 [ 1.412418] init_conntrack.isra.0+0x6c8/0x770 [ 1.412422] ? __pfx_init_conntrack.isra.0+0x10/0x10 [ 1.412424] ? hash_conntrack_raw+0xd9/0x170 [ 1.412425] ? crng_make_state+0x7b/0x180 [ 1.412431] nf_conntrack_in+0x583/0xac0 [ 1.412433] ? __pfx_nf_conntrack_in+0x10/0x10 [ 1.412435] ? __pfx_get_random_u32+0x10/0x10 [ 1.412437] ? __get_random_u32_below+0x16/0x70 [ 1.412439] ? __pfx_ipv4_conntrack_local+0x10/0x10 [ 1.412441] nf_hook_slow+0x75/0x150 [ 1.412444] __ip_local_out+0x20d/0x2f0 [ 1.412449] ? __pfx___ip_local_out+0x10/0x10 [ 1.412451] ? __pfx_dst_output+0x10/0x10 [ 1.412453] ? __pfx_ip_generic_getfrag+0x10/0x10 [ 1.412454] ? __pfx_ip_make_skb+0x10/0x10 [ 1.412456] ip_send_skb+0x31/0xe0 [ 1.412457] udp_send_skb+0x475/0x680 [ 1.412464] udp_sendmsg+0xbe9/0x1150 [ 1.412467] ? __pfx_ip_generic_getfrag+0x10/0x10 [ 1.412468] ? __pfx_udp_sendmsg+0x10/0x10 [ 1.412470] ? __pfx__raw_spin_lock+0x10/0x10 [ 1.412475] ? udp_lib_get_port+0x35b/0xaf0 [ 1.412477] ? __pfx_ip4_datagram_release_cb+0x10/0x10 [ 1.412479] ? __pfx_udp_lib_get_port+0x10/0x10 [ 1.412481] ? __pfx__raw_spin_lock_bh+0x10/0x10 [ 1.412482] ? aa_sk_perm+0x1a0/0x3f0 [ 1.412489] ? __check_object_size+0x4b/0x450 [ 1.412493] ? inet_send_prepare+0x33/0x140 [ 1.412496] __sys_sendto+0x2be/0x2e0 [ 1.412500] ? __pfx___sys_sendto+0x10/0x10 [ 1.412502] ? __pfx_inet_bind_sk+0x10/0x10 [ 1.412504] ? __sys_bind+0x168/0x1a0 [ 1.412506] ? __pfx_ksys_write+0x10/0x10 [ 1.412509] __x64_sys_sendto+0x76/0x90 [ 1.412511] do_syscall_64+0xc7/0x6c0 [ 1.412514] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 1.412521] RIP: 0033:0x423de7 [ 1.412525] Code: c7 c0 ff ff ff ff eb be 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 80 3d 7d 12 09 00 00 41 89 ca 74 10 b8 2c 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 69 c3 55 48 89 e5 53 48 83 ec 38 44 89 4d d0 [ 1.412526] RSP: 002b:00007ffeaf8f5098 EFLAGS: 00000202 ORIG_RAX: 000000000000002c [ 1.412531] RAX: ffffffffffffffda RBX: 00007ffeaf8f50c0 RCX: 0000000000423de7 [ 1.412533] RDX: 0000000000000007 RSI: 0000000000488257 RDI: 0000000000000004 [ 1.412534] RBP: 00007ffeaf8f50f0 R08: 00007ffeaf8f50c0 R09: 0000000000000010 [ 1.412535] R10: 0000000000000000 R11: 0000000000000202 R12: 00007ffeaf8f5228 [ 1.412535] R13: 00007ffeaf8f5238 R14: 00000000004af868 R15: 0000000000000001 [ 1.412537] [ 1.412538] ---[ end trace ]--- Fixes: 076a0ca02644 ("netfilter: ctnetlink: add NAT support for expectations") Signed-off-by: Hyunwoo Kim --- net/netfilter/nf_conntrack_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index c9d725fc2d71..fac75128dfb9 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -3497,6 +3497,8 @@ ctnetlink_parse_expect_nat(const struct nlattr *attr, exp->saved_addr = nat_tuple.src.u3; exp->saved_proto = nat_tuple.src.u; exp->dir = ntohl(nla_get_be32(tb[CTA_EXPECT_NAT_DIR])); + if (exp->dir >= IP_CT_DIR_MAX) + return -EINVAL; return 0; #else -- 2.43.0