From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netfilter.org (mail.netfilter.org [217.70.190.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD3A61A6800 for ; Fri, 20 Mar 2026 11:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.190.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774007214; cv=none; b=k9XTzKz0IVfRWqpswU/BeUyPP/RSwBGj9ZIk4yQ9Yg4RC9aDUJTX1zy/WSz4SOuy2+ZzzjOwjuBLVY2SUKbBSDzVMEwx/Zs7MkGYi8h7KLODy1+GhN8LfEn5oaiFRLaERjMZ+wNPFAGYRHvlBpMPG1MOosSR2FXEz9r7re6qB94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774007214; c=relaxed/simple; bh=x7CAjI/ggsEfOdnWsbh25AQDFXcvbXBDgZm7AdTzht0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z+jMDuK1HeCzz+P/S5HsYadPsQBPUCXew3LAGILhnRuptu+fjjd8tsBHWRaNVopB0kYgjUMz5/cor8l3Yku2a20r5Iw+G5qYT2fq16TVrtgquk0/YwkCA5IQ1lPjX1dEyEum4d7S5PS5bKHwdjiyX7GSODreN4W2UZcIIY4uV5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=netfilter.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b=bggIZ/nO; arc=none smtp.client-ip=217.70.190.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netfilter.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org header.b="bggIZ/nO" Received: from netfilter.org (mail-agni [217.70.190.124]) by mail.netfilter.org (Postfix) with UTF8SMTPSA id 4FA4260181; Fri, 20 Mar 2026 12:46:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org; s=2025; t=1774007209; bh=rA+QX3NxvZyXMTDgEGPJVWztoSEOuOXufKasry/j/DI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bggIZ/nOnsbqkvJMVhg0WzoyX9gLDEly6GJUYTAcHWACKR4fAKbwtYHIZ0q33HN0p WcMPlvwCWBNTNbQenAOQLQCueKRnK7LGzWjXz4xaemU4lH6Es7raD/COKO1j79xBF1 nFyAW1IlV/JfFimM7MtKCZLMTFgOQr67WlI98t31fJBnseul2nbEX+JEQpQpM1maKG OiQ8ws2VzUBXaYzIa8f2mBtNvNciDPIbQRnJ1ks1Qvi3KEk0V6KPXP563OtpJGsOPw 7Z+XENv+lsFFaZyqpgw2Zv8iESjegI1MIZo0Y0J3HhtUycc4jBNHFYbFqjw+OAoi7T vq+yrL0VrILWQ== Date: Fri, 20 Mar 2026 12:46:46 +0100 From: Pablo Neira Ayuso To: Phil Sutter Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nf-next PATCH] netfilter: nfnetlink_hook: Dump nat type chains Message-ID: References: <20260313153220.19662-1-phil@nwl.cc> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Mar 20, 2026 at 12:26:24PM +0100, Phil Sutter wrote: > On Fri, Mar 20, 2026 at 12:18:31PM +0100, Florian Westphal wrote: > > Phil Sutter wrote: > > > On Fri, Mar 20, 2026 at 11:17:00AM +0100, Phil Sutter wrote: > > > [...] > > > > A remark from a practical perspective: Florian's suggestion to dump the > > > > nat-type chains in their order with the dispatcher's priority value is > > > > super-easy to implement (just have to pass the priority value to > > > > nfnl_hook_dump_one() via parameter) and does not require adjustments in > > > > user space. > > > > > > Famous last words. :( > > > > diff --git a/src/mnl.c b/src/mnl.c > > index 4893af8322ae..b9efd3cfd3ce 100644 > > --- a/src/mnl.c > > +++ b/src/mnl.c > > @@ -2520,7 +2520,7 @@ static void basehook_list_add_tail(struct basehook *b, struct list_head *head) > > continue; > > if (!basehook_eq(hook, b)) > > continue; > > - if (hook->prio < b->prio) > > + if (hook->prio <= b->prio) > > continue; > > > > list_add(&b->list, &hook->list); > > > > ? > > Sure, but <=nftables-1.1.6 will still get it wrong. Can we tolerate > that? I think this qualifies as a fix.