public inbox for netfilter-devel@vger.kernel.org
 help / color / mirror / Atom feed
* [ipset PATCH] tests: Fix for standalone calls to setlist_resize.sh
@ 2025-07-22 15:32 Phil Sutter
  2026-03-20 13:39 ` Phil Sutter
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2025-07-22 15:32 UTC (permalink / raw)
  To: Jozsef Kadlecsik; +Cc: netfilter-devel

If called without ip_set.ko loaded, the unconditional 'rmmod ip_set' at
startup will fail and the previous 'set -e' makes that fatal.

Fixes: ed47b815a0d2c ("tests: add namespace test and take into account delayed set removal at module remove")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tests/setlist_resize.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/setlist_resize.sh b/tests/setlist_resize.sh
index acb33e3ba0f08..db347ca065171 100755
--- a/tests/setlist_resize.sh
+++ b/tests/setlist_resize.sh
@@ -20,7 +20,7 @@ while [ $n -le 9 ]; do
     	n=10
     fi
 done
-rmmod ip_set >/dev/null 2>&1
+rmmod ip_set >/dev/null 2>&1 || :
 
 create() {
     n=$1
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [ipset PATCH] tests: Fix for standalone calls to setlist_resize.sh
  2025-07-22 15:32 [ipset PATCH] tests: Fix for standalone calls to setlist_resize.sh Phil Sutter
@ 2026-03-20 13:39 ` Phil Sutter
  0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2026-03-20 13:39 UTC (permalink / raw)
  To: Jozsef Kadlecsik; +Cc: netfilter-devel

On Tue, Jul 22, 2025 at 05:32:05PM +0200, Phil Sutter wrote:
> If called without ip_set.ko loaded, the unconditional 'rmmod ip_set' at
> startup will fail and the previous 'set -e' makes that fatal.
> 
> Fixes: ed47b815a0d2c ("tests: add namespace test and take into account delayed set removal at module remove")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Patch applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-20 13:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-22 15:32 [ipset PATCH] tests: Fix for standalone calls to setlist_resize.sh Phil Sutter
2026-03-20 13:39 ` Phil Sutter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox