public inbox for netfilter-devel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v19 nf-next 5/5] netfilter: nft_chain_filter: Add bridge double vlan and pppoe
Date: Tue, 10 Mar 2026 16:40:26 +0100	[thread overview]
Message-ID: <abA7anfac6z0q3HH@strlen.de> (raw)
In-Reply-To: <58cc080e-1e55-4a51-8c3c-16d6b87794b2@gmail.com>

Eric Woudstra <ericwouds@gmail.com> wrote:
> For me, most is known, as it is probably not very different from other
> places using patchwork.
> 
> What was new and unclear were the AI generated reviews, and what is
> expected in response of them.

Ok.  Basically they should be treated like any other review/comment.

netdev maintainers do pre-filter the AI reviews, to avoid garbage
from hitting list.

In case the AI review is nonsense, just say so.
Same for reviews that might make sense but enter bikeshed territory,
you can always push back, no need to fix up everything.

Just like with human requests [ albeit, if maintainer tells to
'do x', its a bit harder to push back of course 8-) ]

  reply	other threads:[~2026-03-10 15:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  6:53 [PATCH v19 nf-next 0/5] conntrack: bridge: add double vlan, pppoe and pppoe-in-q Eric Woudstra
2026-02-24  6:53 ` [PATCH v19 nf-next 1/5] net: pppoe: avoid zero-length arrays in struct pppoe_hdr Eric Woudstra
2026-02-24 14:15   ` Florian Westphal
2026-02-24  6:53 ` [PATCH v19 nf-next 2/5] netfilter: utils: nf_checksum(_partial) correct data!=networkheader Eric Woudstra
2026-02-24  6:53 ` [PATCH v19 nf-next 3/5] netfilter: bridge: Add conntrack double vlan and pppoe Eric Woudstra
2026-02-25  1:52   ` [v19,nf-next,3/5] " Jakub Kicinski
2026-02-24  6:53 ` [PATCH v19 nf-next 4/5] netfilter: nft_set_pktinfo_ipv4/6_validate: Add nhoff argument Eric Woudstra
2026-02-25  1:52   ` [v19,nf-next,4/5] " Jakub Kicinski
2026-02-24  6:53 ` [PATCH v19 nf-next 5/5] netfilter: nft_chain_filter: Add bridge double vlan and pppoe Eric Woudstra
2026-03-10  8:37   ` Eric Woudstra
2026-03-10 12:39     ` Florian Westphal
     [not found]     ` <abAOwZDmHjcLIbj1@chamomile>
     [not found]       ` <f69a9456-5047-4044-aa8d-1bad3bd81f4b@gmail.com>
2026-03-10 13:26         ` Florian Westphal
2026-03-10 14:45           ` Eric Woudstra
2026-03-10 15:40             ` Florian Westphal [this message]
2026-03-11 10:07   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abA7anfac6z0q3HH@strlen.de \
    --to=fw@strlen.de \
    --cc=ericwouds@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox