From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Jeremy Sowden <jeremy@azazel.net>
Subject: Re: [nft PATCH] Revert "tests: py: use `os.unshare` Python function"
Date: Fri, 13 Mar 2026 16:57:55 +0100 [thread overview]
Message-ID: <abQ0A_cRQ3zym1J-@orbyte.nwl.cc> (raw)
In-Reply-To: <20260313104414.21686-1-phil@nwl.cc>
On Fri, Mar 13, 2026 at 11:44:14AM +0100, Phil Sutter wrote:
> This reverts commit c29407ab300f8ed54b5ca27cf4837c0aab920760.
>
> This change breaks 'time' expression tests in py test suite. It looks
> like with os.unshare, modifications to os.environ are lost. Neither
> unshare module nor unshare command suffer from this problem.
>
> Fixes: c29407ab300f8 ("tests: py: use `os.unshare` Python function")
> Suggested-by: Jeremy Sowden <jeremy@azazel.net>
> Suggested-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2026-03-13 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:44 [nft PATCH] Revert "tests: py: use `os.unshare` Python function" Phil Sutter
2026-03-13 15:57 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abQ0A_cRQ3zym1J-@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox