From: Florian Westphal <fw@strlen.de>
To: Guanni Qu <qguanni@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
kadlec@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_nat_sip: validate exp->dir in nf_nat_sip_expected()
Date: Sun, 15 Mar 2026 08:26:53 +0100 [thread overview]
Message-ID: <abZfPZvV1lpmLW89@strlen.de> (raw)
In-Reply-To: <CAFzOa17xzzjC6U7rC647kA-mT9FTMvX+V1Tc7isxeaP4+P5oww@mail.gmail.com>
Guanni Qu <qguanni@gmail.com> wrote:
> Hi Florian, Pablo,
>
> You're right, the root cause is the missing ctnetlink validation
> that Florian's patch fixes. I hit this crash while testing SIP NAT
> with crafted expectations via ctnetlink, which is how exp->dir
> ended up out of range.
Thanks for confirming, I'll drop it from pachwork.
prev parent reply other threads:[~2026-03-15 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 20:13 [PATCH] netfilter: nf_nat_sip: validate exp->dir in nf_nat_sip_expected() Jenny Guanni Qu
2026-03-13 23:32 ` Florian Westphal
2026-03-14 11:50 ` Pablo Neira Ayuso
2026-03-14 22:21 ` Guanni Qu
2026-03-15 7:26 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abZfPZvV1lpmLW89@strlen.de \
--to=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=qguanni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox