From: Florian Westphal <fw@strlen.de>
To: Kit Dallege <xaum.io@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, Claude <noreply@anthropic.com>
Subject: Re: [PATCH 2/3] netfilter: add missing kernel-doc parameters for nf_hook()
Date: Mon, 16 Mar 2026 09:01:27 +0100 [thread overview]
Message-ID: <abe418p9j1ljge-4@strlen.de> (raw)
In-Reply-To: <20260315154619.50964-1-xaum.io@gmail.com>
Kit Dallege <xaum.io@gmail.com> wrote:
> /**
> * nf_hook - call a netfilter hook
> + * @pf: protocol family (e.g. NFPROTO_IPV4)
> + * @hook: hook number (e.g. NF_INET_PRE_ROUTING)
> + * @net: network namespace
> + * @sk: socket associated with the packet, or NULL
> + * @skb: socket buffer holding the packet
> + * @indev: input network device, or NULL
> + * @outdev: output network device, or NULL
> + * @okfn: function to call if the hook allows the packet to pass
> *
I tend towards not applying this, I don't think this adds any value,
the arguments are rather obvious for anyone doing kernel networking
and its not a utility/library function either.
prev parent reply other threads:[~2026-03-16 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 15:46 [PATCH 2/3] netfilter: add missing kernel-doc parameters for nf_hook() Kit Dallege
2026-03-16 8:01 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe418p9j1ljge-4@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=noreply@anthropic.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=xaum.io@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox