netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Haller <thaller@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 5/6] build: drop recursive make for "examples/Makefile.am"
Date: Fri, 08 Sep 2023 13:50:47 +0200	[thread overview]
Message-ID: <abf258a4f449cd7f4e98fe7094bc46104351f9ac.camel@redhat.com> (raw)
In-Reply-To: <ZPsA1x32YIAMAlR8@orbyte.nwl.cc>

On Fri, 2023-09-08 at 13:09 +0200, Phil Sutter wrote:
> On Fri, Aug 25, 2023 at 01:27:37PM +0200, Thomas Haller wrote:
> [...]
> > +check_PROGRAMS += examples/nft-buffer
> > +
> > +examples_nft_buffer_AM_CPPFLAGS = -I$(srcdir)/include
> > +examples_nft_buffer_LDADD = src/libnftables.la
> > +
> > +check_PROGRAMS += examples/nft-json-file
> > +
> > +examples_nft_json_file_AM_CPPFLAGS = -I$(srcdir)/include
> > +examples_nft_json_file_LDADD = src/libnftables.la
> 
> Does this replace or extend AM_CPPFLAGS/LDADD for the example
> programs?
> IOW, do the global AM_CPPFLAGS added in the previous patch leak into
> the
> example program compile calls or not?
> 
> Cheers, Phil
> 


Replace.


Described here:
https://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html

Basically, if you explicitly define CFLAGS,CPPFLAGS,LDFLAGS,etc for a
target like

inst_LTLIBRARIES = /path/to/libtarget.la
path_to_libtarget_CPPFLAGS = -ABC

then this gets build with $(path_to_libtarget_CPPFLAGS) $(CPPFLAGS).

Otherwise, it gets $(AM_CPPFLAGS) $(CPPFLAGS)



Thomas


  reply	other threads:[~2023-09-08 11:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 11:27 [PATCH nft 0/6] no recursive make Thomas Haller
2023-08-25 11:27 ` [PATCH nft 1/6] build: drop recursive make for "include/**/Makefile.am" Thomas Haller
2023-08-25 11:27 ` [PATCH nft 2/6] build: drop recursive make for "py/Makefile.am" Thomas Haller
2023-08-25 11:27 ` [PATCH nft 3/6] build: drop recursive make for "files/**/Makefile.am" Thomas Haller
2023-08-25 11:27 ` [PATCH nft 4/6] build: drop recursive make for "src/Makefile.am" Thomas Haller
2023-08-25 11:27 ` [PATCH nft 5/6] build: drop recursive make for "examples/Makefile.am" Thomas Haller
2023-09-08 11:09   ` Phil Sutter
2023-09-08 11:50     ` Thomas Haller [this message]
2023-08-25 11:27 ` [PATCH nft 6/6] build: drop recursive make for "doc/Makefile.am" Thomas Haller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf258a4f449cd7f4e98fe7094bc46104351f9ac.camel@redhat.com \
    --to=thaller@redhat.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).