From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACAE7194C98 for ; Wed, 18 Mar 2026 15:50:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773849010; cv=none; b=NZ3HCJ8xzPPpv9Th1eOXe/dQzEglwICugO2CcwnyULjLgrQ8H84Lomp1ZwwkpwR4SL2Ym74GNCeT1whJBszVRYdyvLxWJw1/eakA1NWtTSaqtEwK1Vc5nrVTdVIu7JgDsxNnrfIlexyPpelIIw1ThMECFp8Xq4OsSbmYIMDV5uY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773849010; c=relaxed/simple; bh=nRC98jvHWdkdWwIgs0/ZvzJOJvgB+vAjP0ymRwhYLrA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sv5Jv9Rcb0ZS2g0QcRSMQjaHWsadSWPTKl7PDdLA1TWaq5LhXW7PF45ih0l1S/nH3S4Zi+L242MGaL8mvJx2Qk0enbcxkQBOu5v7dFSQ3QiRNnIVJgt1jzPg42/SGMXjOyQLEtk4DTwNB+tfkRhva6/5eHY093bevY6WzRfQljc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id 3BEEA605C3; Wed, 18 Mar 2026 16:50:05 +0100 (CET) Date: Wed, 18 Mar 2026 16:50:00 +0100 From: Florian Westphal To: Chris Arges Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nf,v4] netfilter: nft_set_rbtree: revisit array resize logic Message-ID: References: <20260317170721.12396-1-pablo@netfilter.org> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Chris Arges wrote: > > Reported-by: Chris Arges > > Fixes: 7e43e0a1141d ("netfilter: nft_set_rbtree: translate rbtree to array for binary search") > > Signed-off-by: Pablo Neira Ayuso > > --- > > v4: use maybe_grow: goto tag instead of grow: > > Add note in commit description: "The shrink logic is skipped by anonymous sets." > > > > I will be able to testing this more in depth early next week. Thanks, I will hold off on this patch and will defer it to next week then.