From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] arptables: Warn when ignoring '-p' option
Date: Fri, 3 Apr 2026 12:52:34 +0200 [thread overview]
Message-ID: <ac-b8tqhhnYTSlKT@lemonverbena> (raw)
In-Reply-To: <20260402145216.32228-1-phil@nwl.cc>
On Thu, Apr 02, 2026 at 04:52:16PM +0200, Phil Sutter wrote:
> Legacy arptables has been silently ignoring this flag (plus mandatory
> argument) since day 1. Retain compatibility to that behaviour but inform
> users that a part of their rule does nothing.
>
> Since arp is the only family which didn't provide a proto_parse
> callback, implement one for the sole purpose of printing the warning. As
> a side-effect, caller no longer has to check callback's existence.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
next prev parent reply other threads:[~2026-04-03 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 14:52 [iptables PATCH] arptables: Warn when ignoring '-p' option Phil Sutter
2026-04-03 10:52 ` Pablo Neira Ayuso [this message]
2026-04-04 9:38 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac-b8tqhhnYTSlKT@lemonverbena \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox