Re: [PATCH next] netfilter: nf_conntrack_h323: Correct indentation when H323_TRACE defined

Andy Shevchenko
2026-03-27T09:24:58Z

On Thu, Mar 26, 2026 at 10:18:09PM +0000, David Laight wrote:
> On Thu, 26 Mar 2026 21:24:39 +0100
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Thu, Mar 26, 2026 at 08:18:19PM +0000, david.laight.linux@gmail.com wrote:
> > >
> > > The trace lines are indented using PRINT("%*.s", xx, " ").
> > > Userspace will treat this as "%*.0s" and will output no characters
> > > when 'xx' is zero, the kernel treats it as "%*s" and will output
> > > a single ' ' - which is probably what is intended.
> > >
> > > Change all the formats to "%*s" removing the default precision.
> > > This gives a single space indent when level is zero.
> >
> > Do you have a setup using this helper? Or you just found this via
> > visual inspection?
>
> Found with grep looking for places which might be affected by 'fixing'
> the kernel printf code to be POSIX compliant.

Do we have the respective test case in printf_kunit?

--
With Best Regards,
Andy Shevchenko