From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Xiang Mei <xmei5@asu.edu>,
netfilter-devel@vger.kernel.org, Phil Sutter <phil@nwl.cc>,
coreteam@netfilter.org, Weiming Shi <bestswngs@gmail.com>
Subject: Re: [PATCH nf] netfilter: nfnetlink_osf: fix divide-by-zero in OSF_WSS_MODULO
Date: Tue, 14 Apr 2026 13:11:58 +0200 [thread overview]
Message-ID: <ad4g_guOwNXWxd40@strlen.de> (raw)
In-Reply-To: <ad4elUEYrkQ18iX8@chamomile>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> @@ -329,6 +332,15 @@ static int nfnl_osf_add_callback(struct sk_buff *skb,
> if (f->opt[i].kind == OSFOPT_MSS && f->opt[i].length < 4)
> return -EINVAL;
>
> + switch (f->wss.wc) {
> + case OSF_WSS_MODULO:
> + if (f->wss.val == 0)
> + return -EINVAL;
> + break;
> + default:
> + break;
> + }
> +
> tot_opt_len += f->opt[i].length;
> if (tot_opt_len > MAX_IPOPTLEN)
> return -EINVAL;
>
> If no concerns, I will post a patch.
Thanks Pablo, LGTM.
next prev parent reply other threads:[~2026-04-14 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 20:48 [PATCH nf] netfilter: nfnetlink_osf: fix divide-by-zero in OSF_WSS_MODULO Xiang Mei
2026-04-11 7:56 ` Fernando Fernandez Mancera
2026-04-11 20:41 ` Florian Westphal
2026-04-14 11:01 ` Pablo Neira Ayuso
2026-04-14 11:11 ` Florian Westphal [this message]
2026-04-14 22:00 ` Xiang Mei
-- strict thread matches above, loose matches on Subject: below --
2026-04-14 11:17 Pablo Neira Ayuso
2026-04-14 21:58 ` Xiang Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4g_guOwNXWxd40@strlen.de \
--to=fw@strlen.de \
--cc=bestswngs@gmail.com \
--cc=coreteam@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox