From: Florian Westphal <fw@strlen.de>
To: Scott Mitchell <scott.k.mitch1@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: nfnetlink_queue crashes kernel
Date: Fri, 3 Apr 2026 21:14:03 +0200 [thread overview]
Message-ID: <adARe9HW3emmdj6q@strlen.de> (raw)
In-Reply-To: <CAFn2buDAPLPjS5fXejDiuY5pV1rduMes2Ho=sSYmFVMVmh5xAw@mail.gmail.com>
Scott Mitchell <scott.k.mitch1@gmail.com> wrote:
> > diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
> > index 47f7f62906e2..15c6276f6592 100644
> > --- a/net/netfilter/nfnetlink_queue.c
> > +++ b/net/netfilter/nfnetlink_queue.c
> > @@ -60,29 +60,10 @@
> > */
> > #define NFQNL_MAX_COPY_RANGE (0xffff - NLA_HDRLEN)
>
> NFQNL_HASH_MIN (1024) and NFQNL_HASH_MAX(1048576) were set when the
> table was global, but if table is moved to per queue it can likely be
> reduced. Suggested values:
>
> #define NFQNL_HASH_MIN 8
> #define NFQNL_HASH_MAX 32768
Changed, thanks.
> Should `netlink_unregister_notifier(&nfqnl_dev_notifier);` be
> 'unregister_netdevice_notifier(&nfqnl_dev_notifier);' ?
Yes, thanks.
next prev parent reply other threads:[~2026-04-03 19:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 12:22 nfnetlink_queue crashes kernel Florian Westphal
2026-04-03 13:45 ` Florian Westphal
2026-04-03 15:55 ` Scott Mitchell
2026-04-03 19:14 ` Florian Westphal [this message]
2026-04-03 23:57 ` Fernando Fernandez Mancera
2026-04-04 9:40 ` Florian Westphal
2026-04-06 12:54 ` Fernando Fernandez Mancera
2026-04-06 17:10 ` Florian Westphal
2026-04-06 20:04 ` Fernando Fernandez Mancera
2026-04-06 14:01 ` Fernando Fernandez Mancera
2026-04-03 13:59 ` Florian Westphal
2026-04-03 14:02 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adARe9HW3emmdj6q@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=scott.k.mitch1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox