Re: [BUG] netfilter: nft_set_pipapo_avx2: rp not reset on goto next_match retry after expired/inactive last-field element

[Florian Westphal <fw@strlen.de>]

boz baba <bababoz943@gmail.com> wrote:
> While auditing the pipapo set lookup in v6.1.133 (the bug is also present
> on current mainline as of this writing) I noticed a logic error in the

Why are you auditing ancient kernel releases?

> Affected file / function
> ------------------------
> 
>   net/netfilter/nft_set_pipapo_avx2.c :: nft_pipapo_avx2_lookup()
> 
> Relevant excerpt (line numbers from v6.1.133):
> 
>   1137 :  const u8 *rp = (const u8 *)key;
>   ...
>   1175 :  nft_pipapo_avx2_prepare();
>   1176 :
>   1177 :  next_match:
>   1178 :  nft_pipapo_for_each_field(f, i, m) {
>   1179 :      bool last = i == m->field_count - 1, first = !i;
>   ...
>   1188 :      NFT_SET_PIPAPO_AVX2_LOOKUP(8, 1);     /* consumes rp */
>   ...
>   1223 :      if (ret < 0)
>   1224 :          goto out;
>   1225 :
>   1226 :      if (last) {
>   1227 :          *ext = &f->mt[ret].e->ext;
>   1228 :          if (unlikely(nft_set_elem_expired(*ext) ||
>   1229 :                       !nft_set_elem_active(*ext, genmask))) {
>   1230 :              ret = 0;
>   1231 :              goto next_match;            /* <-- restarts loop */
>   1232 :          }
>   1233 :          goto out;
>   1234 :      }

This looks very different in mainline. AFAICS this bug was fixed?