Linux Netfilter development
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC nf 0/2] netfilter: add restrictions/validations for packet rewrites
Date: Thu, 4 Jun 2026 01:11:17 +0200	[thread overview]
Message-ID: <aiC0lYKyD5UDQgLS@strlen.de> (raw)
In-Reply-To: <aiCtz2nBZL1Q-gmL@chamomile>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > If anyone is breaking with ilegals field, they should come here to
> > explain? Data plane validation might look safer ... but it will just
> > drop packets and it will take a bit more time to the user to debug.
> > But your approach is more conservative, it just leave the packet
> > untouch, so it is basically ignoring the invalid mangling.

Yes, ignore resp. BREAK verdict.

> Hm. Actually, it is harder than it seems to do this from control plane
> because dscp needs to deal with bitwise to ensure that ihl and version
> are not modified.

Yes, there are cases like those where control plane valition is not
possible.  I will address the AI comments and resubmit w.o. RFC tag.

Thanks for reviewing.

  reply	other threads:[~2026-06-03 23:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 12:11 [RFC nf 0/2] netfilter: add restrictions/validations for packet rewrites Florian Westphal
2026-05-27 12:11 ` [RFC nf 1/2] netfilter: nfnetlink_queue: restrict writes to network header Florian Westphal
2026-05-27 12:11 ` [RFC nf 2/2] netfilter: nftables: restrict linklayer and network header writes Florian Westphal
2026-06-03 22:33 ` [RFC nf 0/2] netfilter: add restrictions/validations for packet rewrites Pablo Neira Ayuso
2026-06-03 22:42   ` Pablo Neira Ayuso
2026-06-03 23:11     ` Florian Westphal [this message]
2026-06-04  6:17       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiC0lYKyD5UDQgLS@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox