From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v4 2/5] netfilter: nf_conncount: use per nf_conncount_data spinlocks
Date: Fri, 5 Jun 2026 16:40:43 +0200 [thread overview]
Message-ID: <aiLf6wZh7GXBt0cd@strlen.de> (raw)
In-Reply-To: <20260605131123.19435-3-fw@strlen.de>
Florian Westphal <fw@strlen.de> wrote:
> - data = kmalloc_obj(*data);
> + data = kvzalloc_obj(*data);
AI suggest to add GFP_KERNEL_ACCOUNT here, but I don't plan to send
a new version just for this (it would likely only trigger more
goal-post-change comments).
The other comment in patch 5 is largely academic and not really
and issue.
next prev parent reply other threads:[~2026-06-05 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 13:11 [PATCH nf-next v4 0/5] netfilter: nf_conncount: fix gc and rbtree bugs Florian Westphal
2026-06-05 13:11 ` [PATCH nf-next v4 1/5] netfilter: nf_conncount: callers must hold rcu read lock Florian Westphal
2026-06-05 13:11 ` [PATCH nf-next v4 2/5] netfilter: nf_conncount: use per nf_conncount_data spinlocks Florian Westphal
2026-06-05 14:40 ` Florian Westphal [this message]
2026-06-05 13:11 ` [PATCH nf-next v4 3/5] netfilter: nf_conncount: split count_tree_node rbtree walk into helper Florian Westphal
2026-06-05 13:11 ` [PATCH nf-next v4 4/5] netfilter: nf_conncount: add sequence counter to detect tree modifications Florian Westphal
2026-06-05 13:11 ` [PATCH nf-next v4 5/5] netfilter: nf_conncount: gc and rcu fixes Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiLf6wZh7GXBt0cd@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox