From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] intervals: Fix for inconsistent union field use
Date: Wed, 17 Jun 2026 18:03:55 +0200 [thread overview]
Message-ID: <ajLFa6v1_aM6ItH8@orbyte.nwl.cc> (raw)
In-Reply-To: <20260603184715.1366533-1-phil@nwl.cc>
On Wed, Jun 03, 2026 at 08:47:15PM +0200, Phil Sutter wrote:
> Reported by a static code analyzer: key->value belongs to a different
> struct in the embedded anonymous union than key->range.* which is
> accessed elsewhere in that function.
>
> It is correct in that the function asserts key->etype to be
> EXPR_RANGE_VALUE, so key->value is not necessarily valid (it just
> happens to match key->range.low's offset.
>
> Fixes: 91dc281a82ea6 ("src: rework singleton interval transformation to reduce memory consumption")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch applied.
prev parent reply other threads:[~2026-06-17 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 18:47 [nft PATCH] intervals: Fix for inconsistent union field use Phil Sutter
2026-06-17 16:03 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajLFa6v1_aM6ItH8@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox