From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, lorenzo@kernel.org,
chzhengyang2023@lzu.edu.cn
Subject: Re: [PATCH nf,v2 2/3] netfilter: flowtable: IPIP tunnel hardware offload is not yet support
Date: Tue, 7 Jul 2026 12:46:42 +0200 [thread overview]
Message-ID: <akzZEhCyHWq95gGB@chamomile> (raw)
In-Reply-To: <akzVhnsxasPRga8H@strlen.de>
On Tue, Jul 07, 2026 at 12:31:34PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > No driver supports for IPIP tunnels yet, give up early on setting up the
> > hardware offload for this scenario.
>
> This series triggers many drive-by findings.
>
> No big deal, should be addressed later.
>
> > + __set_bit(NF_FLOW_HW, &flow->flags);
>
> Would you mind if I mangle this to use set_bit() ?
Go ahead.
> Its a low-hanging fruit, the other findings need
> more attention.
Yes.
> Otherwise I can also apply this as-is, its an improvement
> in either case.
I will follow with other comments, they are pointing to relevant
issues.
next prev parent reply other threads:[~2026-07-07 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 9:40 [PATCH nf,v2 1/3] netfilter: flowtable: use dst in this direction when pushing IPIP header Pablo Neira Ayuso
2026-06-30 9:40 ` [PATCH nf,v2 2/3] netfilter: flowtable: IPIP tunnel hardware offload is not yet support Pablo Neira Ayuso
2026-06-30 10:18 ` Lorenzo Bianconi
2026-07-07 10:31 ` Florian Westphal
2026-07-07 10:46 ` Pablo Neira Ayuso [this message]
2026-06-30 9:40 ` [PATCH nf,v2 3/3] netfilter: flowtable: support IPIP tunnel with direct xmit Pablo Neira Ayuso
2026-06-30 10:19 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akzZEhCyHWq95gGB@chamomile \
--to=pablo@netfilter.org \
--cc=chzhengyang2023@lzu.edu.cn \
--cc=fw@strlen.de \
--cc=lorenzo@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox