From: Florian Westphal <fw@strlen.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jaeyeong Lee <iostreampy@proton.me>,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
phil@nwl.cc
Subject: Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash
Date: Sun, 12 Jul 2026 09:40:16 +0200 [thread overview]
Message-ID: <alNE4AO9H0HGLc34@strlen.de> (raw)
In-Reply-To: <2026071235-geometric-snowdrift-bb4c@gregkh>
Greg KH <gregkh@linuxfoundation.org> wrote:
> > I think this function should WARN_ON_ONCE when one tries to reinsert a
> > dead expectation (and return -EINVAL or another appropriate error).
> >
> > (This is indenpendent of the real fix).
>
> If you do that, then the machine will reboot, loosing everything.
> Are you sure you want that to happen?
Of course not, i never set panic_on_warn.
> Why not just properly handle the
> issue if it possibly could happen?
This is no different than the WARNs on list corruption or refcount
under/overflows.
Would you propose to remove those? I hope not, they help catch bugs.
next prev parent reply other threads:[~2026-07-12 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 23:19 netfilter: nf_nat_sip expectation UAF permits local privilege escalation Jaeyeong Lee
2026-07-11 5:29 ` Greg KH
2026-07-11 14:21 ` [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash Jaeyeong Lee
2026-07-11 16:29 ` Florian Westphal
2026-07-12 5:54 ` Greg KH
2026-07-12 7:40 ` Florian Westphal [this message]
2026-07-12 7:54 ` Greg KH
2026-07-12 8:08 ` Florian Westphal
2026-07-12 8:20 ` Greg KH
2026-07-12 8:40 ` panic_on_warn and lack of lesser-WARN (was: Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash) Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alNE4AO9H0HGLc34@strlen.de \
--to=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=iostreampy@proton.me \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox