From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 6/6] netlink: Call tunnel getters unconditionally
Date: Wed, 22 Jul 2026 18:57:10 +0200 [thread overview]
Message-ID: <amD2ZqPDRpu0R4ia@chamomile> (raw)
In-Reply-To: <akeHC8TJrsAJZwkG@orbyte.nwl.cc>
On Fri, Jul 03, 2026 at 11:55:23AM +0200, Phil Sutter wrote:
> Hi Pablo,
>
> On Fri, Jun 26, 2026 at 01:53:27PM +0200, Pablo Neira Ayuso wrote:
> > Series LGTM, only one nitpick, see below.
>
> Thanks for your review!
>
> [...]
> > > static struct expr *
> > > -netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int attr)
> > > +netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int attr, int alt_attr)
> >
> > Maybe I would suggest:
> >
> > netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int ipv4_attr, int ipv6_attr)
> >
> > for easier reading.
>
> Fine with me! I'll introduce 'int attr' auto-variable then, because the
> code would otherwise conditionally do 'ipv4_attr = ipv6_attr' which is
> more confusing than the original version.
Ok, thanks. Feel free to merge this series once you're done with it.
prev parent reply other threads:[~2026-07-22 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 19:29 [nft PATCH 0/6] Eliminate variable declarations in switch cases Phil Sutter
2026-06-03 19:29 ` [nft PATCH 1/6] json: Introduce tunnel_obj_print_json() Phil Sutter
2026-06-03 19:29 ` [nft PATCH 2/6] parser_json: Introduce json_parse_tunnel() Phil Sutter
2026-06-03 19:29 ` [nft PATCH 3/6] rule: Turn obj_print_comment() into obj_print_header() Phil Sutter
2026-06-03 19:29 ` [nft PATCH 4/6] rule: Introduce tunnel_obj_print_data() Phil Sutter
2026-06-03 19:29 ` [nft PATCH 5/6] src: Avoid variable declarations in switch cases Phil Sutter
2026-06-03 19:29 ` [nft PATCH 6/6] netlink: Call tunnel getters unconditionally Phil Sutter
2026-06-26 11:53 ` Pablo Neira Ayuso
2026-07-03 9:55 ` Phil Sutter
2026-07-22 16:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amD2ZqPDRpu0R4ia@chamomile \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox