From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next,v2 3/5] net: do not advance stack index from dev_fwd_path()
Date: Mon, 27 Jul 2026 16:25:12 +0200 [thread overview]
Message-ID: <amdqSFbQNIl863xq@chamomile> (raw)
In-Reply-To: <amdSK06EPRaTk4Ra@lore-desk>
On Mon, Jul 27, 2026 at 02:42:19PM +0200, Lorenzo Bianconi wrote:
[...]
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index c1c1be1a6962..ca65d1dcd604 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -742,9 +742,9 @@ EXPORT_SYMBOL_GPL(dev_fill_metadata_dst);
> >
> > static struct net_device_path *dev_fwd_path(struct net_device_path_stack *stack)
> > {
> > - int k = stack->num_paths++;
> > + int k = stack->num_paths;
> >
> > - if (k >= NET_DEVICE_PATH_STACK_MAX)
> > + if (k + 1 >= NET_DEVICE_PATH_STACK_MAX)
>
> nit: do we really need k in this case? (ignore the comment if you do not
> need to repost).
Yes, I can do that. I will have to repost anyway, sashiko did not kick in.
next prev parent reply other threads:[~2026-07-27 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 11:59 [PATCH nf-next,v2 1/5] netfilter: flowtable: consolidate net_device field in nft_forward_info struct Pablo Neira Ayuso
2026-07-27 11:59 ` [PATCH nf-next,v2 2/5] netfilter: flowtable: consolidate flowtable device check Pablo Neira Ayuso
2026-07-27 11:59 ` [PATCH nf-next,v2 3/5] net: do not advance stack index from dev_fwd_path() Pablo Neira Ayuso
2026-07-27 12:42 ` Lorenzo Bianconi
2026-07-27 14:25 ` Pablo Neira Ayuso [this message]
2026-07-27 11:59 ` [PATCH nf-next,v2 4/5] net: pass dst via net_device_path in dev_fill_forward_path() Pablo Neira Ayuso
2026-07-27 11:59 ` [PATCH nf-next,v2 5/5] netfilter: flowtable: release tunnel route on error when building forward path Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amdqSFbQNIl863xq@chamomile \
--to=pablo@netfilter.org \
--cc=lorenzo@kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox