From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Avinash Duduskar <avinash.duduskar@gmail.com>
Cc: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] datatype: accept a numeric cgroupsv2 id on input
Date: Wed, 29 Jul 2026 13:43:50 +0200 [thread overview]
Message-ID: <amnndnoOMoR05sJK@chamomile> (raw)
In-Reply-To: <20260729100356.387951-1-avinash.duduskar@gmail.com>
On Wed, Jul 29, 2026 at 03:33:56PM +0530, Avinash Duduskar wrote:
> On Wed, Jul 29, 2026 at 11:13:47AM +0200, Phil Sutter wrote:
> > Is it true that integer_type_parse respects negative values as such?
> > Because that void avoid the mentioned issue of '-1' becoming '1'.
> > Negative values would just not match.
>
> No, the sign parses but is dropped on export: "-1" stores as element 1
> and "-2" then lists as "cgroup.procs". Garbage in, garbage out either
> way, as you say, so v2 delegates to integer_type_parse().
>
> For the metainfo dump test I will take the jq route, as a follow-up.
Regarding this misparsing of -1, I think this issue is related to the
integer parser, which can be revisited in a follow up patch.
I'd suggest to fix the removal of cgroupsv2 by inode id, then look
into improving the integer parser.
next prev parent reply other threads:[~2026-07-29 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 8:24 [PATCH nft] datatype: accept a numeric cgroupsv2 id on input Avinash Duduskar
2026-07-28 16:19 ` Phil Sutter
2026-07-28 19:16 ` Pablo Neira Ayuso
2026-07-28 20:19 ` Avinash Duduskar
2026-07-28 20:31 ` Pablo Neira Ayuso
2026-07-28 20:55 ` Avinash Duduskar
2026-07-29 9:21 ` Phil Sutter
2026-07-29 9:13 ` Phil Sutter
2026-07-29 10:03 ` Avinash Duduskar
2026-07-29 11:43 ` Pablo Neira Ayuso [this message]
2026-07-29 14:19 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amnndnoOMoR05sJK@chamomile \
--to=pablo@netfilter.org \
--cc=avinash.duduskar@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox